Lower ordinal priority of page decorator #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combined with JENKINS-54325, this fixes the known issue of the login and signup pages not looking right. Signed-off-by: Matt Sicker <boards@gmail.com>
Wadeck
approved these changes
Nov 12, 2018
Contributor
|
@jvz tests need to be fixed, I imagine is the version of the core that is no longer sync-up |
Member
Author
|
The test is failing correctly; it'll work again once this PR is updated to be based on the Jenkins core version fixed in the referenced PR. |
Contributor
|
@jvz do you want to merge it like that or wait for that PR to be merged and then publish an incremental of core to see the tests passing? |
Member
Author
|
I'll rebuild the upstream PR to try to get an incremental release. The previous build had a flaky test fail it looks like, so no incremental was published. Then I can update this PR with that version. |
This integrates the upstream changes for simple page decorators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined with JENKINS-54325 and jenkinsci/jenkins#3721, this fixes the known issue of the login and
signup pages not looking right.
Signed-off-by: Matt Sicker boards@gmail.com
@reviewbybees