[JENKINS-52417] - Removing FilePath.copyFromRemotely

[jglick]

In favor of jenkinsci/apache-httpcomponents-client-4-api-plugin#9 as picked up by jenkinsci/workflow-basic-steps-plugin#60 & jenkinsci/copyartifact-plugin#104, the only places where this method had been called.

Changelog entry

• RFE - Developer: Remove hudson.FilePath#copyFromRemotely() Beta API from the core

[daniel-beck]

Is this the first case of breaking updates due to Beta annotations?

[jglick]

Is this the first case of breaking updates due to Beta annotations?

Yes, though the user impact should be zero since the calls to copyFromRemotely are only made when encountering a VirtualFile implementing toExternalURL, which only exists in artifact-manager-s3, which has never been released to the UC.

[oleg-nenashev]

Ready to merge once @jglick confirms it

[oleg-nenashev]

@jglick please follow the PR template and create a changelog entry proposal. Although the API is not used elsewhere, IMHO it is important to make it changelogged since the API is in LTS.

Maybe we also want to create a follow-up patch to 2.107.x Stable branch and change annotation to@Restricted(DoNotUse.class) there

[jglick]

All makes sense.

On hold until referenced PRs are merged.

[jglick]

jenkinsci/workflow-basic-steps-plugin#60 need not be merged first, since that is the same PR where this API was first used—has just been open that long. jenkinsci/copyartifact-plugin#104 ought to be merged and released first (implying a release of jenkinsci/apache-httpcomponents-client-4-api-plugin#9), since otherwise there could be an artifact-manager-s3 release which offers external URLs which is used on a Jenkins without copyFromRemotely but copyartifact 1.40 which tries to call it, leading to a linkage error. @ikedam is maintainer, no response so far, so TBD.

[jglick]

jenkinsci/copyartifact-plugin#104 has been merged but not yet released, so this is still on hold.

[jglick]

Trying to trigger a fresh build.

[oleg-nenashev]

Created https://issues.jenkins-ci.org/browse/JENKINS-52417 for it. IMHO tickets must be always required for Beta API removal. The change will need to be backported as discussed above

[oleg-nenashev]

Added the changelog entry