Using RobustHTTPClient utility for artifact downloads

[jglick]

Picks up jenkinsci/apache-httpcomponents-client-4-api-plugin#9 so that network problems need not be fatal. Follows up #100.

[ikedam]

Looks good to me.

@jglick
Let me know about jenkinsci/apache-httpcomponents-client-4-api-plugin#9 . It says that RobustHTTPClient is a beta API. And it's annotated with Restricted(Beta.class). Will the annotation be removed when releasing apache-httpcomponents-client-4-api-plugin-4.5.5-2.2? If not, how Restricted(Beta.class) works when this request is merged?

As far as I had a quick look on Beta.class, the check by maven should fail without useBeta=true, but it looks succeed even without useBeta=true for apache-httpcomponents-client-4-api-plugin.

[jglick]

Will the annotation be removed

Not that quickly, no.

it looks succeed even without useBeta=true for apache-httpcomponents-client-4-api-plugin

The property is set on the plugin consuming the beta API.

[svanoort]

I do not have enough 👍 to give in approval of this. Glad to see it.

[ikedam]

it looks succeed even without useBeta=true for apache-httpcomponents-client-4-api-plugin
The property is set on the plugin consuming the beta API.

Oh, I see. I misunderstood that.

It looks annotated as beta for VirtualFile#toExternalURL is beta.
https://github.com/jenkinsci/jenkins/blob/jenkins-2.121/core/src/main/java/jenkins/util/VirtualFile.java#L352

[jglick]

@ikedam do you have a plan to release this? jenkinsci/jenkins#3480 remains on hold until then.

[ikedam]

@jglick
I plan to make a new release after resolving #105.

[ikedam]

@jglick I released copyartifact-1.41 with this change.