Skip to content

Test with Java 17 in addition to Java 11 and Java 8 #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkEWaite merged 5 commits into from
Apr 6, 2022
Merged

Test with Java 17 in addition to Java 11 and Java 8 #1249

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9419f1
Test with Java 17 in addition to Java 11 and Java 8
MarkEWaite Apr 6, 2022
7686620
Remove argLine override to fix Java 17 build
MarkEWaite Apr 6, 2022
c8e4e1f
Actually test Java 17
MarkEWaite Apr 6, 2022
e711ad8
Remove unused source encoding setting
MarkEWaite Apr 6, 2022
6b8a319
Remove h3 from javadoc
MarkEWaite Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

buildPlugin(failFast: false,
configurations: [
[platform: 'linux', jdk: '11'],
[platform: 'windows', jdk: '8'],
[platform: 'linux', jdk: '11', jenkins: '2.342'],
Copy link
Member

@jglick jglick Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean

Suggested change
[platform: 'linux', jdk: '11', jenkins: '2.342'],
[platform: 'linux', jdk: '17', jenkins: '2.342'],

?

On the mailing list you posted a stack trace from CliGitSCMTriggerLocalPollTest but of course that is not visible in CI because you are not actually running Java 17.

Copy link
Contributor Author

@MarkEWaite MarkEWaite Apr 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. Made the same change in multiple repositories and failed to finish the job in this one.

Fixed the mistake in c8e4e1f

[platform: 'linux', jdk: '11'],
[platform: 'windows', jdk: '8'],
])