Test with Java 17 in addition to Java 11 and Java 8 #1249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
reviewed
Apr 6, 2022
Jenkinsfile
Outdated
| configurations: [ | ||
| [platform: 'linux', jdk: '11'], | ||
| [platform: 'windows', jdk: '8'], | ||
| [platform: 'linux', jdk: '11', jenkins: '2.342'], |
Member
There was a problem hiding this comment.
Did you mean
Suggested change
| [platform: 'linux', jdk: '11', jenkins: '2.342'], | |
| [platform: 'linux', jdk: '17', jenkins: '2.342'], |
?
On the mailing list you posted a stack trace from CliGitSCMTriggerLocalPollTest but of course that is not visible in CI because you are not actually running Java 17.
Contributor
Author
There was a problem hiding this comment.
Thanks for catching that. Made the same change in multiple repositories and failed to finish the job in this one.
Fixed the mistake in c8e4e1f
Member
|
Running locally I do see I do see earlier in the build as expected. The test passes with diff --git pom.xml pom.xml
index 34e29fa1..afe0d153 100644
--- pom.xml
+++ pom.xml
@@ -62,7 +62,6 @@
<changelist>-SNAPSHOT</changelist>
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <argLine>-Dfile.encoding=${project.build.sourceEncoding}</argLine>
<jenkins.version>2.289.1</jenkins.version>
<no-test-jar>false</no-test-jar>
<useBeta>true</useBeta>Not sure why Lines 64 to 65 in 1435a5e @basil is it known that an explicit |
Member
|
(Or we could introduce a property like |
Basil explained:
> [You are] overriding the <argLine> from the plugin parent POM in your
> plugin POM. This override is not extending the original value but
> replacing it, just as overriding a method in a subclass without calling
> super() in Java code would replace the original method rather than
> extend it. As of 4.39 this meant that your plugin was blanking out the
> -Xms, -Xmx, -XX:HeapDumpOnOutOfMemoryError, -XX:TieredCompilation, and
> -XX:TieredStopAtLevel settings from the plugin parent POM – incorrect,
> but harmless. As of 4.40, this means your plugin is blanking out the
> @{jenkins.addOpens} and @{jenkins.insaneHook} settings from the plugin
> parent POM – incorrect, and harmful when running on Java 17.
Nice improvement to remove an unhelpful setting.
Earlier change did not actually test Java 17.
Contributor
Author
|
Also removed the source encoding setting without seeing any negative affect on compile time messages. See e711ad8 |
Java 17 does not accept it
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Java 17 in additional to Java 11 and Java 8
Use Java 17 in the Jenkinsfile to compile and test.
Tests are failing with a serialization error. I need more guidance on the changes needed to fix the failing tests.
Checklist
Types of changes