-
Notifications
You must be signed in to change notification settings - Fork 250
Combined settings and card #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
852e45a
Use card layout for credentials tables
timja b633bf9
Refine card UI
janfaracik 27276a3
Adjust colors + padding
janfaracik 10b4636
Update domain items
janfaracik 8d9e091
Add Configure button
janfaracik 9302a64
Add credential count
janfaracik 2f8f1dd
Start migrating home page
janfaracik e30d6ed
WIP homepage cards
janfaracik a06256d
Update credentials.css
janfaracik 08fd291
Fixes
janfaracik 600c93d
Refine further
janfaracik 1a1805b
Update credentials.css
janfaracik 4a94613
Add missing check
timja 4bcb15b
Remove no longer needed brackets
timja b6353cd
Fix non editable stores showing actions
timja 850049f
Add empty state support
timja 2947831
Remove unneeded brackets around description
timja ce2e83f
Drop the .
janfaracik a5ed6be
Switch to adjunct for settings-subpage compat
timja 4d4c975
Initial credentials implementation of experimental views
timja 9b78fe1
Add to system store
timja a13bf61
More
timja e8b22c4
More progress
timja 4e0655f
Should be all the system pages
timja 37bd9b2
Mostly fix it up
timja 9297ea1
Drop job page rework change
timja 6ded96c
Address Jan feedback
timja df4a321
Update incremental
timja b9347b6
Update bom
timja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
src/main/java/com/cloudbees/plugins/credentials/links/DeleteCredentialsLink.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package com.cloudbees.plugins.credentials.links; | ||
|
|
||
| public class DeleteCredentialsLink { | ||
| public String getDisplayName() { | ||
| return Messages.DeleteCredentialsLink_displayName(); | ||
| } | ||
| } | ||
7 changes: 7 additions & 0 deletions
7
src/main/java/com/cloudbees/plugins/credentials/links/DeleteDomainLink.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package com.cloudbees.plugins.credentials.links; | ||
|
|
||
| public class DeleteDomainLink { | ||
| public String getDisplayName() { | ||
| return Messages.DeleteDomainLink_displayName(); | ||
| } | ||
| } | ||
7 changes: 7 additions & 0 deletions
7
src/main/java/com/cloudbees/plugins/credentials/links/MoveCredentialsLink.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package com.cloudbees.plugins.credentials.links; | ||
|
|
||
| public class MoveCredentialsLink { | ||
| public String getDisplayName() { | ||
| return Messages.MoveCredentialsLink_displayName(); | ||
| } | ||
| } | ||
7 changes: 7 additions & 0 deletions
7
src/main/java/com/cloudbees/plugins/credentials/links/NewCredentialsLink.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package com.cloudbees.plugins.credentials.links; | ||
|
|
||
| public class NewCredentialsLink { | ||
| public String getDisplayName() { | ||
| return Messages.NewCredentialsLink_displayName(); | ||
| } | ||
| } |
7 changes: 7 additions & 0 deletions
7
src/main/java/com/cloudbees/plugins/credentials/links/NewDomainLink.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package com.cloudbees.plugins.credentials.links; | ||
|
|
||
| public class NewDomainLink { | ||
| public String getDisplayName() { | ||
| return Messages.NewDomainLink_displayName(); | ||
| } | ||
| } | ||
7 changes: 7 additions & 0 deletions
7
src/main/java/com/cloudbees/plugins/credentials/links/UpdateCredentialsLink.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package com.cloudbees.plugins.credentials.links; | ||
|
|
||
| public class UpdateCredentialsLink { | ||
| public String getDisplayName() { | ||
| return Messages.UpdateCredentialsLink_displayName(); | ||
| } | ||
| } |
7 changes: 7 additions & 0 deletions
7
src/main/java/com/cloudbees/plugins/credentials/links/UpdateDomainLink.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package com.cloudbees.plugins.credentials.links; | ||
|
|
||
| public class UpdateDomainLink { | ||
| public String getDisplayName() { | ||
| return Messages.UpdateDomainLink_displayName(); | ||
| } | ||
| } | ||
44 changes: 31 additions & 13 deletions
44
.../com/cloudbees/plugins/credentials/CredentialsStoreAction/CredentialsWrapper/delete.jelly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,33 @@ | ||
| <?jelly escape-by-default='true'?> | ||
| <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:i="jelly:fmt"> | ||
| <l:layout title="${%Delete credentials}" permission="${it.domain.parent.DELETE}"> | ||
| <st:include page="sidepanel.jelly" /> | ||
| <l:main-panel> | ||
| <h1>${%Delete credentials}</h1> | ||
| <form method="post" action="doDelete"> | ||
| <p>${%confirm(it.displayName,it.typeName)}</p> | ||
| <div> | ||
| <f:submit value="${%Yes}"/> | ||
| </div> | ||
| </form> | ||
| </l:main-panel> | ||
| </l:layout> | ||
| <j:jelly xmlns:j="jelly:core" xmlns:d="jelly:define" xmlns:local="local" xmlns:l="/lib/layout" | ||
| xmlns:f="/lib/form"> | ||
|
|
||
| <d:taglib uri="local"> | ||
| <d:tag name="contents"> | ||
| <form method="post" action="doDelete"> | ||
| <p>${%confirm(it.displayName,it.typeName)}</p> | ||
| <div> | ||
| <f:submit value="${%Yes}" clazz="jenkins-!-destructive-color"/> | ||
| </div> | ||
| </form> | ||
| </d:tag> | ||
| </d:taglib> | ||
|
|
||
| <j:choose> | ||
| <j:when test="${it.store.context == app}"> | ||
| <l:settings-subpage managementLink="${it.deleteLink}" includeBreadcrumb="true" | ||
| noDefer="true" permission="${it.domain.parent.DELETE}"> | ||
|
|
||
| <local:contents/> | ||
| </l:settings-subpage> | ||
| </j:when> | ||
| <j:otherwise> | ||
| <l:layout type="one-column" title="${it.displayName}" permission="${it.domain.parent.DELETE}"> | ||
| <l:main-panel> | ||
| <l:app-bar title="${it.deleteLink.displayName}"/> | ||
| <local:contents/> | ||
| </l:main-panel> | ||
| </l:layout> | ||
| </j:otherwise> | ||
| </j:choose> | ||
| </j:jelly> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the best for long display names with sidepanel:
It just gets truncated with no way to view the full name
cc @janfaracik
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assume that would be a core fix, but I can get a temp fix in this plugin if wanted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to fix in core as its just using standard controls.
We can possibly also fix by not using the display name on that page and using the ID or description.
The display name field contains duplicated information for a lot of credential types e.g. description...