Skip to content

Conversation

@timja
Copy link
Member

@timja timja commented Dec 21, 2025

Combines #984 and #981

Not for review

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

</table>
<j:set var="safeDescription"
value="${d.description==null?null:app.markupFormatter.translate(d.description)}"/>
<div class="credentials-card">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

card overflow when there's a sidepanel on 13" screen doesn't look great:

Text is:

C=XX,ST=StateName,L=CityName,O=CompanyName,OU=CompanySectionName,CN=CommonNameOrHostname

image

cc @janfaracik

Copy link
Member

@janfaracik janfaracik Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Fixed - good spot - pushed to #984


<j:set var="header">
<l:view>
<l:app-bar title="${it.displayName}">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the best for long display names with sidepanel:

image

It just gets truncated with no way to view the full name

cc @janfaracik

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume that would be a core fix, but I can get a temp fix in this plugin if wanted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to fix in core as its just using standard controls.

We can possibly also fix by not using the display name on that page and using the ID or description.
The display name field contains duplicated information for a lot of credential types e.g. description...

@timja timja force-pushed the settings-with-card branch from 585c067 to b9347b6 Compare December 21, 2025 22:02
@timja timja closed this Dec 30, 2025
@timja timja deleted the settings-with-card branch December 30, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants