-
Notifications
You must be signed in to change notification settings - Fork 250
Combined settings and card #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| </table> | ||
| <j:set var="safeDescription" | ||
| value="${d.description==null?null:app.markupFormatter.translate(d.description)}"/> | ||
| <div class="credentials-card"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
card overflow when there's a sidepanel on 13" screen doesn't look great:
Text is:
C=XX,ST=StateName,L=CityName,O=CompanyName,OU=CompanySectionName,CN=CommonNameOrHostname
cc @janfaracik
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed - good spot - pushed to #984
|
|
||
| <j:set var="header"> | ||
| <l:view> | ||
| <l:app-bar title="${it.displayName}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the best for long display names with sidepanel:
It just gets truncated with no way to view the full name
cc @janfaracik
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assume that would be a core fix, but I can get a temp fix in this plugin if wanted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to fix in core as its just using standard controls.
We can possibly also fix by not using the display name on that page and using the ID or description.
The display name field contains duplicated information for a lot of credential types e.g. description...
585c067 to
b9347b6
Compare
Combines #984 and #981
Not for review
Testing done
Submitter checklist