Use card layout for credentials tables #984

timja · 2025-12-19T22:54:06Z

Goal of this is to reduce duplication of information in e.g.:

Whilst making it easier to read and understand.
Also should stop credentials with longer names of descriptions from overflowing and breaking out of the page.

Root action before

Root action after

The above highlights that the display names are not the best for all credential types. I think its optimised for the credentials picker dropdown, but not great for the credentials list, I'd like to look at this if I have time but not for this PR

Domain

Empty state domain modifiable

Empty state domain not modifiable

Empty state root action

Testing done

Added a few credentials of differing types.
Added ones without description
Tested with read only stores (Azure key vault)

Ath passed as at b8944f9 in jenkinsci/acceptance-test-harness#2565

cc @janfaracik

Submitter checklist

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests that demonstrate the feature works or the issue is fixed

timja · 2025-12-19T22:55:41Z

...resources/com/cloudbees/plugins/credentials/CredentialsStoreAction/DomainWrapper/index.jelly

+                   value="${c.description==null?'':app.markupFormatter.translate(c.description)}"/>
+
+            <div class="credentials-wrapper">
+              <div class="credentials-card">


I started with the jenkins-card but its title can't take html / an icon and I don't think its flexible enough for this sort of thing.

I used the exact same layout and css as the API tokens card but didn't want to reuse the classes as they aren't part of the API.

cc @mawinter69

janfaracik · 2025-12-20T08:10:48Z

Looking good!

Just a few 8am ideas:

Any thoughts on having the list styled like the dashboard prototype? (experimental-dashboard-refine)
- My current thinking is is that items that can be moved around are separated, e.g. a vertical gap in between them, items that cannot be moved (e.g. jobs, credentials, New Item page) are joined
Any thoughts on more use of dialogs? E.g. the add credentials page, delete, move
- And if they are dialogs, do we even need the pages for the credentials? Is it common to deep link to credentials?
Any thoughts on showing usages on the item itself? (e.g. used N times)

... could I get commit permissions to your fork 🙏

timja · 2025-12-20T08:14:57Z

Looking good!

Just a few 8am ideas:

Any thoughts on having the list styled like the dashboard prototype? (experimental-dashboard-refine)

My current thinking is is that items that can be moved around are separated, e.g. a vertical gap in between them, items that cannot be moved (e.g. jobs, credentials, New Item page) are joined

Sure sounds good

Any thoughts on more use of dialogs? E.g. the add credentials page, delete, move

Definitely delete and move could be dialogs, they are very simple pages.
New credentials probably as well.

And if they are dialogs, do we even need the pages for the credentials? Is it common to deep link to credentials?

Any thoughts on showing usages on the item itself? (e.g. used N times)

Makes sense, (assuming not expensive to get)

... could I get commit permissions to your fork 🙏

Done, go to https://github.com/timja/credentials-plugin/invitations

janfaracik · 2025-12-20T09:21:08Z

Adjusted the cards:

There's a whole bunch of fancy focus states that aren't in this (that are in the dashboard concept) - but I'd like to have this be a component in core we can just reuse rather than reinvent the wheel every time.

timja · 2025-12-20T23:31:31Z

@janfaracik thanks for the help!

I've fixed up a few permissions issues where it wasn't quite right for credentials providers that you can't update from directly inside Jenkins (I tested with the Azure Key Vault plugin).

I've also added empty states for when there's no credentials.

Not the biggest fan of the root tables one as I haven't added a call to action due to there being multiple stores and how you can disable them etc I’d like to add this in a follow up

I've created a PR to ATH as well.

Anything else before this is ready do you think?

janfaracik · 2025-12-21T09:44:06Z

Anything else before this is ready do you think?

Looks good to me 🚀

janfaracik · 2025-12-22T08:42:05Z

Can anybody think of a good ionicon to replace this? (https://ionic.io/ionicons)

I can always make one if needed.

timja · 2025-12-22T08:45:40Z

Can anybody think of a good ionicon to replace this? ([ionic.io/ionicons](https://ionic.io/ionicons))
I can always make one if needed.

server-outline or business-outline?

FYI there's also icons showing on the action overflow menus that should be updated. (Move etc)

janfaracik · 2025-12-22T09:03:28Z

server-outline or business-outline?

Ugh I was searching for tower but couldn't find anything - business works well.

FYI there's also icons showing on the action overflow menus that should be updated. (Move etc)

Aye - will do those in a follow up once we move to modals, hoping to kill the breadcrumb actions...

timja · 2025-12-22T10:44:42Z

Ideally shouldn't have update in the more actions menu and in the main area:

(I do wonder if we need the more actions or the update it makes it a bit quicker but the only frequent actions would be new credentials and update a credential

timja · 2025-12-30T17:27:35Z

@jglick possible to take a look at this please?

jglick

A display nit. Otherwise seems OK to me from very brief local testing, but I lack any context for why you are redesigning GUI here. If you plan to work on a lot of stuff like this you should just request write access to the repo.

jglick · 2025-12-30T17:42:58Z

src/main/resources/lib/credentials/store.jelly

+                       class="jenkins-badge">
+                        <j:choose>
+                            <j:when test="${domain.global}">
+                                ${%global}


nearly illegible for me in Firefox

Probably requires jenkinsci/jenkins@17abe4f#diff-39fd25ee020b2666775defabaaa2349f0cf5d77b65be30ceb02119e60f307be2

(2.535)

Works on 2.504.x, changes a bit on 2.535 to look better:

Will need to increase it again soon but will leave it conservative for this PR.

Would file separately but Windows tests in this repo are rediculously slow

jtnord · 2026-01-05T11:41:53Z

@timja this removed the model links from the "Stores" section of the overview page so you can no longer quickly add credentials or domains from the overview page, now you need to go to another page and then click introducing an uneeded step? This to me is a UX regression for power users, and I hope this was unintentional and can be restored?

timja · 2026-01-05T11:43:46Z

@timja this removed the model links from the "Stores" section of the overview page so you can no longer quickly add credentials or domains from the overview page, now you need to go to another page and then click introducing an uneeded step? This to me is a UX regression for power users, and I hope this was unintentional and can be restored?

New credentials is going to be added this week in #992 with a better experience.

Is new domains really needed? Are they used much at all?

jtnord · 2026-01-05T11:47:37Z

New credentials is going to be added this week in #992 with a better experience.

❤️

Is new domains really needed? Are they used much at all?

I personally rarely use them, and there are none that I see in CloudBees' instances. But that is possibly as they are currently hard to understand (there is no reason why a github PAT should not be in a domain for github.com - I think its partially the UX to create them is messy and does not guide people to use them, and partially that they do not restrict credentials in them to being used on those domains, but rather restricts requests with a domain to only those credentials). TBH as they are so rarely used we could possibly change that behaviour to make them actually more useful!

timja · 2026-01-05T12:37:11Z

The new credentials is ready now if you want to take a look. I’m working on ATH and will run it through pct although not expecting anything there

jglick · 2026-01-05T15:23:55Z

IMO the concept of credentials domains was never needed and could be deprecated.

jglick · 2026-01-05T21:26:26Z

src/main/java/com/cloudbees/plugins/credentials/CredentialsStore.java

+     * @return the icon class name for the store.
+     * @since TODO
+     */
+    public final String getIconClassName() {


This broke several CredentialsStore implementations in CloudBees CI which were implementing IconSpec (and thus defining their own getIconClassName methods). Is there a recommended migration?

timja requested a review from a team as a code owner December 19, 2025 22:54

timja marked this pull request as draft December 19, 2025 22:54

timja commented Dec 19, 2025

View reviewed changes

timja mentioned this pull request Dec 20, 2025

Adapt credentials plugin for cards jenkinsci/acceptance-test-harness#2563

Merged

6 tasks

timja added the enhancement label Dec 20, 2025

timja marked this pull request as ready for review December 21, 2025 08:07

This was referenced Dec 21, 2025

Combined settings and card #985

Closed

Introduce dialogs for credentials actions #986

Open

janfaracik mentioned this pull request Dec 26, 2025

Remove breadcrumb context menu #990

Merged

6 tasks

timja mentioned this pull request Dec 27, 2025

Test credentials wizard PR jenkinsci/acceptance-test-harness#2565

Draft

6 tasks

jglick approved these changes Dec 30, 2025

View reviewed changes

timja mentioned this pull request Dec 30, 2025

Add timja to credentials plugin jenkins-infra/repository-permissions-updater#4867

Merged

7 tasks

timja enabled auto-merge (squash) December 30, 2025 21:48

timja and others added 7 commits December 30, 2025 21:51

Use card layout for credentials tables

4c5b9ca

Refine card UI

d04b667

Adjust colors + padding

af8b1e0

Update domain items

84a38e1

Add Configure button

b54d2c9

Add credential count

221cd44

Start migrating home page

d348efb

timja and others added 18 commits December 30, 2025 21:51

Add empty state support

e78f847

Remove unneeded brackets around description

fe5718b

Drop the .

451d6ae

Switch to adjunct for settings-subpage compat

17bdf0f

Fix text wrap, fix icon shrinking + alignment

73c94f1

Fix description wrap

275d125

Pull out Stores into own Jelly file

9753ab3

Use symbol-business-outline plugin-ionicons-api

1113246

Fix page description spacing

2250dba

Use dialog for deleting domains

ad653e4

Use dialog for deleting credentials

a9b60f1

Update index.jelly

aaff327

Fix ATH

8604f37

Use different icon for globals

80f5dbe

Use user avatar for user stores - happy to revert if not right approach

0781ef4

Update CredentialsStore.java

c19f8c2

Don't need to export iconClassName

c3818b6

Increase baseline for jenkins-badge

362ecf0

timja force-pushed the card branch from 7d07bd6 to 362ecf0 Compare December 30, 2025 21:51

Adjust junit5 import from not up-to date branch

0e3a77f

Would file separately but Windows tests in this repo are rediculously slow

timja merged commit 7291f84 into jenkinsci:master Dec 30, 2025
19 checks passed

timja deleted the card branch December 30, 2025 22:53

jtnord mentioned this pull request Jan 5, 2026

New credentials dialog #992

Draft

20 tasks

jglick reviewed Jan 5, 2026

View reviewed changes

jglick mentioned this pull request Jan 5, 2026

Restore compatibility for CredentialsStore implementing IconSpec #1000

Merged

Use card layout for credentials tables #984

Use card layout for credentials tables #984

Uh oh!

Conversation

timja commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing done

Submitter checklist

Uh oh!

timja Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

janfaracik commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timja commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

janfaracik commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timja commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

janfaracik commented Dec 21, 2025

Uh oh!

janfaracik commented Dec 22, 2025

Uh oh!

timja commented Dec 22, 2025

Uh oh!

janfaracik commented Dec 22, 2025

Uh oh!

timja commented Dec 22, 2025

Uh oh!

timja commented Dec 30, 2025

Uh oh!

jglick left a comment

Choose a reason for hiding this comment

Uh oh!

jglick Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

timja Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

timja Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jtnord commented Jan 5, 2026

Uh oh!

timja commented Jan 5, 2026

Uh oh!

jtnord commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timja commented Jan 5, 2026

Uh oh!

jglick commented Jan 5, 2026

Uh oh!

jglick Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

timja commented Dec 19, 2025 •

edited

Loading

janfaracik commented Dec 20, 2025 •

edited

Loading

timja commented Dec 20, 2025 •

edited

Loading

janfaracik commented Dec 20, 2025 •

edited

Loading

timja commented Dec 20, 2025 •

edited

Loading

jtnord commented Jan 5, 2026 •

edited

Loading