Skip to content

Conversation

@NotMyFault
Copy link
Member

The PR bumps the latest LTS release to the first point release and bumps the second last LTS release to the final security release.

@NotMyFault NotMyFault mentioned this pull request Jun 22, 2022
35 tasks
@timja timja added the enhancement New feature or request label Jun 22, 2022
@timja timja enabled auto-merge (squash) June 22, 2022 16:01
@NotMyFault NotMyFault changed the title chore: Bump 2.346 profile to .1 and bump 2.332.4 chore: Bump 2.346 profile to .1 and bump 2.332 to .4 Jun 22, 2022
@timja timja merged commit f3cfb3e into jenkinsci:master Jun 22, 2022
@NotMyFault NotMyFault deleted the chore/master/2.346.1-dot-one branch June 22, 2022 19:10
<properties>
<bom>2.332.x</bom>
<jenkins.version>2.332.1</jenkins.version>
<jenkins.version>2.332.4</jenkins.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow the current doc shows 2.332.3, FYI @daniel-beck (context: jenkins-infra/jenkins.io#4876)

Copy link
Member

@daniel-beck daniel-beck Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/jglick/jenkins.io/blob/aed4f7fd2d70b6325d447d00588d9d86c0acd2a8/content/_layouts/corebaseline.html.haml#L13 is just https://updates.jenkins.io/tiers.json via https://github.com/jenkins-infra/jenkins.io/blob/64ed7120a01fde6d35946423e35da51e4a95fca3/scripts/fetch-external-resources#L54-L55 and it lists versions actually used as dependency only (so we can generate matching update sites).

By now there's half a dozen plugins that depend on 2.332.4, so the site is (currently) fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jetersen
Copy link
Member

@NotMyFault FYI these versions are now fully managed by https://github.com/jenkinsci/bom/blob/master/updatecli/generate-manifests.ps1

I noticed however a bug after reviewing this PR 😅
Potentially a 2.446.x can be set as x.y I assumed in the script it could only be x.y.z let me write a fix 😅

@jetersen
Copy link
Member

jetersen commented Jul 28, 2022

#1344 should correctly handle jenkins.version for weekly or stable whether it is x.y or x.y.z

@NotMyFault
Copy link
Member Author

@NotMyFault FYI these versions are now fully managed by https://github.com/jenkinsci/bom/blob/master/updatecli/generate-manifests.ps1

I noticed however a bug after reviewing this PR 😅 Potentially a 2.446.x can be set as x.y I assumed in the script it could only be x.y.z let me write a fix 😅

Nice, I assume we no longer need to raise PRs to update existing profiles from one point release to another?

@jetersen
Copy link
Member

jetersen commented Jul 28, 2022

Nice, I assume we no longer need to raise PRs to update existing profiles from one point release to another?

Indeed that is the case 👏

Only need to raise PRs when new LTS line comes out.

But potentially that could be automated too 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants