-
Notifications
You must be signed in to change notification settings - Fork 64
chore: Bump 2.346 profile to .1 and bump 2.332 to .4 #1217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump 2.346 profile to .1 and bump 2.332 to .4 #1217
Conversation
| <properties> | ||
| <bom>2.332.x</bom> | ||
| <jenkins.version>2.332.1</jenkins.version> | ||
| <jenkins.version>2.332.4</jenkins.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow the current doc shows 2.332.3, FYI @daniel-beck (context: jenkins-infra/jenkins.io#4876)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/jglick/jenkins.io/blob/aed4f7fd2d70b6325d447d00588d9d86c0acd2a8/content/_layouts/corebaseline.html.haml#L13 is just https://updates.jenkins.io/tiers.json via https://github.com/jenkins-infra/jenkins.io/blob/64ed7120a01fde6d35946423e35da51e4a95fca3/scripts/fetch-external-resources#L54-L55 and it lists versions actually used as dependency only (so we can generate matching update sites).
By now there's half a dozen plugins that depend on 2.332.4, so the site is (currently) fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@NotMyFault FYI these versions are now fully managed by https://github.com/jenkinsci/bom/blob/master/updatecli/generate-manifests.ps1 I noticed however a bug after reviewing this PR 😅 |
|
#1344 should correctly handle jenkins.version for weekly or stable whether it is |
Nice, I assume we no longer need to raise PRs to update existing profiles from one point release to another? |
Indeed that is the case 👏 Only need to raise PRs when new LTS line comes out. But potentially that could be automated too 😉 |
The PR bumps the latest LTS release to the first point release and bumps the second last LTS release to the final security release.