More quickly pick up new LTS releases in version recommendations #5320
Conversation
|
jenkinsci/bom#1217 (comment) I guess? |
The only time this will show a difference is around the release of a new LTS line. If no plugin depends on it yet, it will not be part of
Yes, I missed your comment there until now. |
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
At least does not currently seem to break anything.
| oldest_lts = lts[0] | ||
| supported_lts = site._generated[:core_tiers].stableCores | ||
| oldest_supported_lts = supported_lts[0] | ||
| all_lts = site._generated[:lts_releases].results.map { |v| v.version } |
There was a problem hiding this comment.
IIUC use of this all_lts in next_lts_1 and previous_lts_highs rather than lts is the fix.
| next_lts_1 = all_lts.select { |v| v =~ /[.]1$/ }[0] | ||
| # We assume that supported_lts will contain at least one release of the previous LTS line, which is reasonable. | ||
| # Surely there's going to be at least one plugin depending on the old .1 by the time the next .1 is available. | ||
| previous_lts_highs = supported_lts.map { |v| v[0...-1] }.uniq[0...-1].map { |l| all_lts.select { |v| v.start_with?(l) }[0] } |
There was a problem hiding this comment.
(also here selecting first match from all_lts rather than last match from lts as before)
3 participants
Fixes #5316.
I couldn't quite reuse the existing resource we downloaded (only .1) and was too lazy to adapt https://www.jenkins.io/doc/developer/javadoc/ , so this adds a resource download.