Skip to content

Conversation

@jglick
Copy link
Member

@jglick jglick commented May 24, 2022

@jglick jglick added the removed label May 24, 2022
@timja

This comment was marked as outdated.

@jglick

This comment was marked as outdated.

@jglick jglick added the dependencies Pull requests that update a dependency file label May 25, 2022
@jglick jglick changed the title Add pipeline-groovy-lib; remove 2.289.x line Add pipeline-groovy-lib May 25, 2022
@jglick jglick added enhancement New feature or request and removed dependencies Pull requests that update a dependency file removed labels May 25, 2022
@jglick
Copy link
Member Author

jglick commented May 26, 2022

Note that workflow-cps-global-lib currently still has a 2.303.x dep, so on the 2.289.x line it is still pinned (#788). This seems to cause some weird behavior in that e.g. https://ci.jenkins.io/job/Tools/job/bom/job/PR-1168/5/testReport/org.jenkinsci.plugins.workflow.libs/FolderLibrariesTest/ runs tests twice on 2.289.x, but appears harmless for now. Could be cleaned up if desired by porting jenkinsci/pipeline-groovy-lib-plugin#5 to the deprecated plugin.

@jglick jglick marked this pull request as ready for review May 26, 2022 13:29
@jglick jglick requested review from basil, car-roll, dwnusbaum and jtnord May 26, 2022 13:30
@jglick jglick merged commit 5bcaebc into jenkinsci:master May 26, 2022
@jglick jglick deleted the pipeline-groovy-lib branch May 26, 2022 19:07
@jglick jglick mentioned this pull request May 26, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants