Skip to content

More efficient processor and memory usage #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
novaki wants to merge 11 commits into
base: master
Choose a base branch
from
Open

More efficient processor and memory usage #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
06f935f
Speed up exception checking
novaki May 4, 2015
8fba577
Code cleanup
novaki May 4, 2015
1879dfc
Function: handle is now disposed by garbage collector
novaki May 5, 2015
1be77d3
Function: pass the v8 persistent function handle to structure and table
novaki May 5, 2015
89ca148
Code cleanup
novaki May 5, 2015
068e21c
Function: use less memory when receiving large tables and structs
novaki May 6, 2015
44f9586
Function: Do not build fied descriptions when the result table is empty
novaki May 7, 2015
8ab5dc5
Function: Added query and enumerator callbacks to structure
novaki May 7, 2015
598438b
Function: Fixed compile warnings
novaki May 7, 2015
9f3bcbc
Code cleanup
novaki May 7, 2015
f550931
Function: added setter and deleter interceptor for structures
novaki May 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 8 additions & 25 deletions src/Common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*
/*
-----------------------------------------------------------------------------
Copyright (c) 2011 Joachim Dorner

Expand Down Expand Up @@ -46,15 +46,15 @@ static std::string convertToString(v8::Handle<v8::Value> const &str)
if (s != nullptr) {
return std::string(s, utf8String.length());
}

return emptyString;
}

static std::string convertToString(const SAP_UC *str)
{
v8::HandleScope scope;
v8::Local<v8::String> utf16String = v8::String::New((const uint16_t*)(str));

return convertToString(utf16String);
}

Expand All @@ -80,9 +80,9 @@ static SAP_UC* convertToSAPUC(v8::Handle<v8::Value> const &str) {
static v8::Handle<v8::Value> RfcError(const RFC_ERROR_INFO &info)
{
v8::HandleScope scope;

v8::Local<v8::Value> e = v8::Exception::Error(v8::String::New((const uint16_t*)(info.message)));

v8::Local<v8::Object> obj = e->ToObject();
obj->Set(v8::String::New("code"), v8::Integer::New(info.code));
obj->Set(v8::String::New("group"), v8::Integer::New(info.group));
Expand All @@ -94,36 +94,19 @@ static v8::Handle<v8::Value> RfcError(const RFC_ERROR_INFO &info)
obj->Set(v8::String::New("msgv2"), v8::String::New((const uint16_t*)(info.abapMsgV2)));
obj->Set(v8::String::New("msgv3"), v8::String::New((const uint16_t*)(info.abapMsgV3)));
obj->Set(v8::String::New("msgv4"), v8::String::New((const uint16_t*)(info.abapMsgV4)));

return scope.Close(obj);
}

static v8::Handle<v8::Value> RfcError(const char* message, v8::Handle<v8::Value> value)
{
v8::HandleScope scope;

v8::Local<v8::String> exceptionString = v8::String::Concat(v8::String::New(message), value->ToString());
v8::Local<v8::Value> e = v8::Exception::Error(exceptionString);

return scope.Close(e->ToObject());
return v8::ThrowException(exceptionString);
}

static bool IsException(v8::Handle<v8::Value> value)
{
v8::HandleScope scope;
const v8::Local<v8::Value> sample = v8::Exception::Error(v8::String::New(""));
const v8::Local<v8::String> protoSample = sample->ToObject()->ObjectProtoToString();

if (!value->IsObject()) {
return false;
}
v8::Local<v8::String> protoReal = value->ToObject()->ObjectProtoToString();
if (protoReal->Equals(protoSample)) {
return true;
}
scope.Close(v8::Undefined());

return false;
return value->IsNativeError();
}

#endif /* COMMON_H_ */
Loading