More efficient processor and memory usage #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IsException() method was complicated, so receival of large tables were really slow.
The SAP function handle is managed by the garbage collector, so structures and large arrays will be able to hold reference to it.
Removed debug message.
The structures are not stored in plain objects anymore. ObjectTemplate is utilized to convert SAP data to JS only when it is read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receiving large tables and structures required lots of memory (see #9). The reason was that the addon stored structures in plain v8::Object, created a v8::String for each property and other objects for values. Moreover, all fields of the SAP structures were converted to v8::Object properties, even they were never read.
I've used
v8::ObjectTemplateto represent a SAP structure andv8::ObjectTemplate::SetNamedPropertyHandlerto convert SAP structure properties to JS ones, just-in-time.Finally, IsException() method was really slow, so we practically couldn't receive large tables through RFC. I've used
v8::Value::IsNativeError()to speed up the check.