Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns and flags #147

Merged

Conversation

fsdude
Copy link
Contributor

@fsdude fsdude commented May 28, 2020

Retranslation done. I removed 'article-pt.md' file too, just to keep the quantity of files same as the english.

Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kiniggit, @luizclr, @adriavieira314, @Mr-Saxobeat, please since @fsdude might be unavailable I would appreciate if any of you could review this PR #147 , including my revision.
Thank you.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sine @fsdude is not available, I applied my own changes and will wait for another reviewer.

@odsantos
Copy link
Contributor

Hi @luizclr, @jonnathan-ls , @Mr-Saxobeat, since @fsdude might be unavailable I would appreciate if any of you could review this PR #147.
Thank you.

1 similar comment
@odsantos
Copy link
Contributor

Hi @luizclr, @jonnathan-ls , @Mr-Saxobeat, since @fsdude might be unavailable I would appreciate if any of you could review this PR #147.
Thank you.

@odsantos
Copy link
Contributor

Hi @luizclr , @Mr-Saxobeat , @jonnathan-ls , anyone available for reviewing this PR #147 ? Thanks.

@peruibeloko
Copy link
Contributor

@jonnathan-ls @odsantos esse PR também apresenta o mesmo problema da tradução do pattern:

@odsantos
Copy link
Contributor

odsantos commented Jan 17, 2024

@peruibeloko I'll check and hopefully get back to you soon. Thanks.

Copy link
Contributor

@jonnathan-ls jonnathan-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Eu apliquei as atualizações de trechos que não devem ser traduzidos, conforme commit 91686e7

@jonnathan-ls
Copy link
Contributor

jonnathan-ls commented Jan 20, 2024

... esse PR também apresenta o mesmo problema da tradução do pattern:

Grato pela observação @peruibeloko ❤️

Eu apliquei o ajuste no último commit e na aprovação que deixei 91686e7 \done

@jonnathan-ls
Copy link
Contributor

Hi ... anyone available for reviewing this PR #147 ? Thanks.

@odsantos eu adicionei minha aprovação e a observação que o Peruibeloko registrou de textos que não devem ser traduzidos.

Como você já tinha registrado sua revisão e realizou os ajustes necessários, por gentileza, registrar a aprovação de suas solicitações, para o BOT deste repositório conseguir observar e o status do PR estar condizente na marcação da lista de tarefas (issue 01).

Para registrar a aprovação de sua revisão, basta clicar nos três pontinhos de menu e atualizar com sua aprovação, para que possamos prosseguir com o Merge Request.

image

@nazarepiedady nazarepiedady requested review from a team February 5, 2024 16:34
Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good enough to be approved, so I do it.

@nazarepiedady nazarepiedady merged commit 0218fe7 into javascript-tutorial:master Mar 10, 2024
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants