Skip to content

chore(types): upgrade @types/node 24.13.3 to 24.13.6 - #658

Merged
jasonhnd merged 2 commits into
previewfrom
chore/types-node-24.13.6
Sep 24, 2026
Merged

jasonhnd merged 2 commits into
previewfrom
chore/types-node-24.13.6

Conversation

@jasonhnd

@jasonhnd jasonhnd commented Sep 24, 2026 •

Copy link
Copy Markdown
Owner

Closes #645

Part of #635 (order 9). Base preview. Blocked-by order 8 is f6da94c9 (PR #657).

Edits mapped to やること

  1. Branch chore/types-node-24.13.6 from origin/preview f6da94c9 (order 8 merged). Bun 1.4.2 (1.4.2+744846f84) was already installed at /tmp/bun-1.4.2 and was prepended to PATH. Global Bun was not upgraded (bun upgrade was not run; ~/.bun was not written). Node v24.20.0. No PUBLIC_GA4_MEASUREMENT_ID / PUBLIC_X_PIXEL_ID / PUBLIC_META_PIXEL_ID.
  2. package.json devDependencies["@types/node"]: ^24.13.3 → ^24.13.6. The ^24 major is unchanged. No other range changed. No engines.node. No .nvmrc change. Commit 1a5402cf.
  3. bun install (Bun 1.4.2). See Lockfile.
  4. Standard chain below, run after commit 1a5402cf so git diff --exit-code is the generated-file check. All exit 0. Results match the dry-run table (typecheck / test / build / REQUIRE_BUILT_ARTIFACTS / verify:gates OK; Playwright 356 passed, 26 skipped, 0 failed; bun audit no vulnerabilities).
  5. Docs:
    • CHANGELOG.md ### Changed (commit 1a5402cf): - **@types/node 24.13.3 → 24.13.6** — stays on Node 24 (Vercel does not accept Node 26 yet).
    • docs/TOOLCHAIN.md §2 does not mention @types/node (the current-versions table has no such row). Left unchanged. The only other 24.13.3 mention is historical §5 order 3 of the [UPGRADE] 2026-08 toolchain series (Astro 7.2, Bun 1.4, Playwright, OG 1.0) #280 series (@vercel/edge 1.3.3 + @types/node 24.13.3), which this Issue does not ask to rewrite.
    • docs/TOOLCHAIN.md §11 order 9: — done (#658). Follow-up commit ac94099c. §2 was not edited (no @types/node row).

Lockfile

git diff --numstat f6da94c9 for commit 1a5402cf (before the §11 follow-up):

1	0	CHANGELOG.md
2	2	bun.lock
1	1	package.json

git diff --stat for package.json + bun.lock only:

 bun.lock     | 4 ++--
 package.json | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

That is one package.json line replaced and four bun.lock diff lines (the embedded range, and the resolved package entry's version + integrity). undici-types stays ~7.18.0. bun install wrote the lockfile; it was not hand-edited. lockfileVersion stays 1.

bun install log (Bun 1.4.2, after the range bump):

bun install v1.4.2 (744846f84)
Resolving dependencies
Resolved, downloaded and extracted [2]
Saved lockfile

+ @types/node@24.13.6 (v26.6.2 available)

1 package installed [146.00ms]

Bun printed (v26.6.2 available). It was not installed. Resolved package is @types/node@24.13.6.

Lockfile greps

grep -n '"@types/node": \["@types/node@' bun.lock
290:    "@types/node": ["@types/node@24.13.6", "", { "dependencies": { "undici-types": "~7.18.0" } }, "sha512-SGrw/h3KPFshy3OE6ZL53LMBG5vGQQ8/gIpiqz/kRZhPJ7HgwCEs8LBuNtWLa8dvGZVpSF7+Bf+c11HUrCb/yg=="],

grep -n 'lockfileVersion' bun.lock
2:  "lockfileVersion": 1,

Exactly one ["@types/node@ entry, major 24. Pre-existing transitive "@types/node@14.18.63" strings (two, from packages that declare @types/node ^14) are unchanged and do not match that grep.

node_modules/@types/node version after install: 24.13.6.

Verification (Bun 1.4.2+744846f84, Node v24.20.0)

Chain ran on commit 1a5402cf. Each command exit 0. unset PUBLIC_GA4_MEASUREMENT_ID PUBLIC_X_PIXEL_ID PUBLIC_META_PIXEL_ID before the chain.

bun run typecheck

$ node node_modules/typescript/bin/tsc --noEmit
exit=0

bun run test

bun run test runs build:data then bun test. ETL completed (556 occupations).

bun test v1.4.2 (744846f84)

 1725 pass
 0 fail
Ran 1725 tests across 168 files. [4.31s]
exit=0

sector.test.ts prints two [og] sectors projection schema mismatch lines. Same pre-existing negative fixtures noted on #657; the run is 1725 pass / 0 fail.

bun run build

[check-lockfile-sync] OK — 13 deps match between package.json and bun.lock.
[check-analytics-config] OK — 6 script-src origins ok, 11 connect-src origins ok, 0 frame-src origins ok, 5 PUBLIC_* env vars documented.
[check-nested-html-comments] OK — scanned 71 files, no nested HTML comments.
00:39:27 [build] ✓ Completed in 7.15s.
00:39:27 [build] 844 page(s) built in 7.26s
00:39:27 [build] Complete!
[subset-fonts] 2 font files, serif=1102 sans=2399 unique codepoints, 302 KiB total
[check-geo-freshness] OK - GPT 6 SOL 2026-09-23, 556 occupations, mean=4.55
[check-rendered-leaks] OK — scanned 844 pages, no leaked tokens.
[compute-csp-hashes] OK — script-src/style-src already up to date (24 inline-script + 36 inline-style hash(es), 844 HTML files scanned).
exit=0

The 844 route lines are omitted. CSP hashes unchanged.

REQUIRE_BUILT_ARTIFACTS=1 bun test scripts/home-css-loading.test.ts src/site/models-built.test.ts

bun test v1.4.2 (744846f84)

 10 pass
 0 fail
Ran 10 tests across 2 files. [88.00ms]
exit=0

bun run verify:gates

[OK] projections pass L3 consistency checks
[check-geo-freshness] OK - GPT 6 SOL 2026-09-23, 556 occupations, mean=4.55
[check-model-redirects] OK - 12 bare model slug(s) redirect to their latest run
[check-analytics-spec] OK — 36 events / 46 params match analytics/spec.yaml (5 dynamic emit sites declared).
[check-architecture] no Edge entries — plane C is nodejs/Bun (TOOLCHAIN §9)
[check-architecture] ✓ all enforced layer boundaries respected
[check-doc-links] OK — 58 tracked Markdown files, 99 local link/image target(s)
[verify-occupation-routes] 556 occupations own 556 unique, indexable routes
✅ Internal-link integrity passed — every NEW href resolves; 0 pre-known broken targets remain (TODO).
✅ JSON-LD validation passed — all 843/844 pages structurally valid.
✓ URL set (urls.txt) — 844 URLs
✓ data file paths (data-files.txt) — 616 files
✓ sitemap.xml — 5002 lines
✓ image-sitemap.xml — 3897 lines
✓ SEO metadata (seo-metadata.jsonl) — 844 URLs compared
✓ OG / Twitter meta (og-meta.jsonl) — 844 URLs compared
✓ JSON-LD (json-ld.jsonl) — 844 URLs compared
✓ internal links + anchors (internal-links.jsonl) — 844 URLs compared
✅ SEO baseline clean — no drift.
[check-page-class] §18.7 class membership: OK
[check-design-sync] OK — Design.md §21.2 and design-tokens.ts agree
[check-type-scale] OK — every font-size on a conformant surface is a scale token (0 warning(s))
[check-heading-rules] OK — no conformant surface sets heading type (0 warning(s))
[check-surface-coverage] OK — every file carrying design declarations belongs to a surface
[check-contrast] OK — 33 role × background combinations satisfy §2.2
[check-role-color] OK — every checked role uses its §4.7 colour token (33 roles in the table, 0 warning(s))
[check-color-tokens] OK — no palette tint written raw, data URI colours on palette (98 off-palette colour(s) reported by drift:design)
[compute-csp-hashes] OK — script-src has 24 inline-script hash(es) and matches dist-astro/.
exit=0

bun x playwright test --reporter=line

  26 skipped
  356 passed (20.8s)
exit=0

0 failed. Per-test lines omitted (382 listed: 356 passed + 26 skipped).

bun audit

bun audit v1.4.2 (744846f84)

No vulnerabilities found (checked 438 packages) [179.00ms]
exit=0

git diff --exit-code

exit=0

No output. Working tree clean after the chain (no generated-file drift).

Not changed

  • No @types/node@25 / @26. No engines.node. No .nvmrc change. No other package bumps.
  • This Issue lists no vercel inspect or preview-URL curl. Those were not run.

Vercel

The Issue does not ask for vercel inspect. The PR head check says Canceled by Ignored Build Step, so this is the read-only record of what that means.

  • 1a5402cf (lockfile): GitHub status Deployment has completed → dpl_GWecav3AWJcCno6kb3xYVE8eaRKJ. Build log: bun install v1.4.1 (4661e494f), + @types/node@24.13.6, [check-lockfile-sync] OK — 13 deps match between package.json and bun.lock., Build Completed in /vercel/output [47s]. Preview alias: https://jobs-git-chore-types-node-24136-zkscio.vercel.app
  • ac94099c (§11 only): scripts/vercel-ignore-build.sh skipped the build. That success status is what the PR head shows. It did not replace the deployment above.

Build-image Bun is 1.4.1, which matches TOOLCHAIN §2 (Vercel 1.4.x observed at 1.4.1). lockfileVersion 1 installed under --frozen-lockfile.

Stay on Node 24. Vercel does not accept Node 26 for Builds or Functions yet.

Refs #645
@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
jobs Ready Ready Preview Sep 24, 2026 3:41pm UTC

Request Review

§11 order 9 now points at the PR that moves @types/node to 24.13.6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant