ci: upgrade actions/checkout and actions/setup-node from v4 to v7 - #660
Merged
Merged
Conversation
Clears the Node.js 20 deprecation warning on GitHub-hosted runners. node-version stays 24.x and oven-sh/setup-bun stays v2. Refs #647
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
§11 order 11 now points at the PR that moves checkout and setup-node to v7. §2's CI column does not name an action major, so it is unchanged.
jasonhnd
added a commit
that referenced
this pull request
Sep 24, 2026
This was referenced Sep 24, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #647
Part of #635 (order 11). Base
preview. Parallel-lane ruling 2026-09-24: this branch started from43d1e3b8(PR #658) before order 10 was merged. Order 10 then landed as #659 (95ac84d6). Merge commit128dd5c3keeps both doc lines. The diff againstpreviewis still onlyci.yml(twouses:lines), one CHANGELOG line, and the §11 done mark.Edits mapped to やること
ci/actions-v7fromorigin/preview43d1e3b8. Order 10 was not on that commit; this PR does not changepackage.jsonorbun.lock..github/workflows/ci.yml(commit855e165f), exactly twouses:lines:uses: actions/checkout@v4→uses: actions/checkout@v7uses: actions/setup-node@v4→uses: actions/setup-node@v7node-version: 24.xkept.oven-sh/setup-bun@v2withbun-version: 1.4.2kept.@v7). No SHA pin. Triggers, permissions, concurrency, and every other step unchanged. The "Enforce preview-to-main promotion" step is untouched.actions/checkout@v7,actions/setup-node@v7,oven-sh/setup-bun@v2and a 2-line diff. The js-yaml print matches.git diff --statreports4 ++--forci.ymlbecause each of those two lines is one deletion plus one insertion, plus the CHANGELOG line added in the same commit.qualityon head128dd5c3(run36025548316) is green. Rendered-output Playwright was not run locally (another agent holds port 4321; nobun x playwright test, nobun run test:e2e, noscripts/e2e-server.cjs). The PRqualityjob is the rendered-output suite.CHANGELOG.md### Changed(commit855e165f, kept in the merge):- **CI: actions/checkout and actions/setup-node v4 → v7** — clears the Node 20 deprecation warning; no behaviour change.docs/TOOLCHAIN.md§2 CI column says`24.x` via `actions/setup-node`and does not name an action major (v4/v7). Left unchanged. The Playwright row now says 1.63.0 because chore(e2e): upgrade @playwright/test 1.62.1 to 1.63.0 and dedupe playwright-core #659 updated it; this PR did not edit that cell.docs/TOOLCHAIN.md§11 order 11:— done (#660)(commitc07bc1ea). Order 10's— done (#659)from preview is kept.やらないこと
No other workflow edits. No
cache:input. NopackageManagerfield. No dependency bumps.package-manager-cache: truein the log is setup-node v7 printing its own default; this workflow does not set it, and the step did not restore or save a package-manager cache. TheFound in cacheline is the Node 24 toolcache, which setup-node already used at v4.Verification
node -e(js-yaml), before commit855e165fExit 0. Node
v24.20.0.js-yaml4.3.2 fromnode_modules. TheNO_COLOR/FORCE_COLORline is an environment warning, not a parse failure.git diff --stat(working tree, before commit855e165f)git diff -- .github/workflows/ci.yml(same tree; still the diff againstpreviewat128dd5c3)Quality run
Head
128dd5c3. Run https://github.com/jasonhnd/jobs/actions/runs/36025548316. Job107721028049. Conclusionsuccess.An earlier run on
c07bc1ea(https://github.com/jasonhnd/jobs/actions/runs/36024610489) was the same result before #659 was merged in. Run36024552058(855e165f) was cancelled by the workflow concurrency group whenc07bc1eawas pushed.Set up job
Set up Node.js
node: v24.21.0is the24.xresolution. No npm cache hit or save follows this block.Enforce preview-to-main promotion
Job API: step conclusion
skipped(base ispreview). Skipped steps are omitted from the downloaded log. The step text inci.ymlis unchanged.Later steps
Every step after setup is
success, including unit tests (1725 pass / 0 fail on the earlier run; this run's step issuccess), typecheck, build, rendered HTML contracts, repository gates, Chromium install, rendered-output checks, andgit diff --exit-code.Rendered-output (this run, not a local Playwright process):
No failed line. 356 + 26 = 382. That is the same 356 passed the series dry run recorded and the same count order 10's changelog states ("CI rendered-output suite unchanged: 356 passed").
Annotations
Zero annotations. The log has zero lines containing
Node.js 20. The warning on run35890700262(checkout@v4, setup-node@v4) is absent here.The same command on the pre-merge run
107718224968also returned[].Vercel
gh pr checks/ the rollup:VercelSUCCESS,Vercel Preview CommentsSUCCESS.The first bot comment (tip
c07bc1ea, docs-only against its parent) said Ignored / 1 Skipped Deployment, which isscripts/vercel-ignore-build.shtreating a documentation-only diff as a skip. After128dd5c3the bot comment updated to Ready:The Issue does not list
vercel inspector a curl of the preview URL, so those were not run. No state-changing Vercel command was run.Unsure
actions/setup-nodebut not a major. The Issue says to update that column only if it names action versions, so it was left as-is.git diff --statprints4 ++--for a two-line replacement. That is the dry run's "diff = 2 lines" under git's delete-plus-insert accounting. Nothing else inci.ymlchanged.package-manager-cache: trueby default. It was not added to the workflow, and no package cache was used. Not changed further, because やらないこと forbids other workflow edits.