Skip to content

fix(ui): replace dead href links with javascript:void(0) #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Prateek2007-cmd wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −22
Open

fix(ui): replace dead href links with javascript:void(0) #2258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cart.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@
</li>

<!-- Close Button -->
<a href="#" id="close" aria-label="Close menu" aria-hidden="false">
<a href="javascript:void(0)" id="close" aria-label="Close menu" aria-hidden="false">
<i class="fa-solid fa-xmark"></i>
</a>

Expand Down Expand Up @@ -624,7 +624,7 @@ <h4 style="color: #ffffff !important; font-size: 13px !important; font-weight: 7
<h4 style="color: #ffffff !important; font-size: 14px !important; font-weight: 700 !important; margin: 0 0 10px 0 !important; text-transform: uppercase; letter-spacing: 0.5px;">My Account</h4>
<a href="login.html" style="color: #cbd5e1 !important; font-size: 13px !important; text-decoration: none; margin-bottom: 6px;">Sign In</a>
<a href="cart.html" style="color: #cbd5e1 !important; font-size: 13px !important; text-decoration: none; margin-bottom: 6px;">View Cart</a>
<a href="#" style="color: #cbd5e1 !important; font-size: 13px !important; text-decoration: none; margin-bottom: 6px;">My Wishlist</a>
<a href="javascript:void(0)" style="color: #cbd5e1 !important; font-size: 13px !important; text-decoration: none; margin-bottom: 6px;">My Wishlist</a>
<a href="cart.html" style="color: #cbd5e1 !important; font-size: 13px !important; text-decoration: none; margin-bottom: 6px;">Track Order</a>
<a href="contact.html" style="color: #cbd5e1 !important; font-size: 13px !important; text-decoration: none; margin-bottom: 12px;">Help</a>

Expand Down
36 changes: 18 additions & 18 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
</li>

<!-- Close Button -->
<a href="#" id="close" aria-label="Close menu" aria-hidden="false">
<a href="javascript:void(0)" id="close" aria-label="Close menu" aria-hidden="false">
<i class="fa-solid fa-xmark"></i>
</a>

Expand Down Expand Up @@ -391,7 +391,7 @@ <h5>Cartoon Astronaut T-Shirts</h5>
<h4>&#8377;2,499</h4>
<div class="pro-action-bar">
<button class="pro-buy-btn" aria-label="Buy Cartoon Astronaut T-Shirts" onclick="buyNow('Cartoon Astronaut T-Shirts','₹2,499','images/products/f1.jpg',1,'M')">BUY NOW</button>
<a href="#" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Cartoon Astronaut T-Shirts','₹2,499','images/products/f1.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
<a href="javascript:void(0)" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Cartoon Astronaut T-Shirts','₹2,499','images/products/f1.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
</div>
</div>
</div>
Expand All @@ -408,7 +408,7 @@ <h5>White Palm Leaf Casual Shirt</h5>
<h4>&#8377;1,299</h4>
<div class="pro-action-bar">
<button class="pro-buy-btn" aria-label="Buy Cartoon Astronaut T-Shirts" onclick="buyNow('White Palm Leaf Casual Shirt','₹1,299','images/products/f2.jpg',1,'M')">BUY NOW</button>
<a href="#" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('White Palm Leaf Casual Shirt','₹1,299','images/products/f2.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
<a href="javascript:void(0)" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('White Palm Leaf Casual Shirt','₹1,299','images/products/f2.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
</div>
</div>
</div>
Expand All @@ -425,7 +425,7 @@ <h5>Vintage Rose Garden Shirt</h5>
<h4>&#8377;3,490</h4>
<div class="pro-action-bar">
<button class="pro-buy-btn" aria-label="Buy Cartoon Astronaut T-Shirts" onclick="buyNow('Vintage Rose Garden Shirt','₹3,490','images/products/f3.jpg',1,'M')">BUY NOW</button>
<a href="#" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Vintage Rose Garden Shirt','₹3,490','images/products/f3.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
<a href="javascript:void(0)" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Vintage Rose Garden Shirt','₹3,490','images/products/f3.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
</div>
</div>
</div>
Expand All @@ -442,7 +442,7 @@ <h5>Sakura Blossom Floral Shirt</h5>
<h4>&#8377;2,799</h4>
<div class="pro-action-bar">
<button class="pro-buy-btn" aria-label="Buy Cartoon Astronaut T-Shirts" onclick="buyNow('Sakura Blossom Floral Shirt','₹2,799','images/products/f4.jpg',1,'M')">BUY NOW</button>
<a href="#" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Sakura Blossom Floral Shirt','₹2,799','images/products/f4.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
<a href="javascript:void(0)" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Sakura Blossom Floral Shirt','₹2,799','images/products/f4.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
</div>
</div>
</div>
Expand All @@ -459,7 +459,7 @@ <h5>Pink Peony Patterned Shirt</h5>
<h4>&#8377;1,999</h4>
<div class="pro-action-bar">
<button class="pro-buy-btn" aria-label="Buy Cartoon Astronaut T-Shirts" onclick="buyNow('Pink Peony Patterned Shirt','₹1,999','images/products/f5.jpg',1,'M')">BUY NOW</button>
<a href="#" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Pink Peony Patterned Shirt','₹1,999','images/products/f5.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
<a href="javascript:void(0)" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Pink Peony Patterned Shirt','₹1,999','images/products/f5.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
</div>
</div>
</div>
Expand All @@ -476,7 +476,7 @@ <h5>Dual-Tone Corduroy Shirt</h5>
<h4>&#8377;2,299</h4>
<div class="pro-action-bar">
<button class="pro-buy-btn" aria-label="Buy Cartoon Astronaut T-Shirts" onclick="buyNow('Dual-Tone Corduroy Shirt','₹2,299','images/products/f6.jpg',1,'M')">BUY NOW</button>
<a href="#" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Dual-Tone Corduroy Shirt','₹2,299','images/products/f6.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
<a href="javascript:void(0)" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Dual-Tone Corduroy Shirt','₹2,299','images/products/f6.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
</div>
</div>
</div>
Expand All @@ -493,7 +493,7 @@ <h5>Embroidered Linen Trousers</h5>
<h4>&#8377;3,990</h4>
<div class="pro-action-bar">
<button class="pro-buy-btn" aria-label="Buy Cartoon Astronaut T-Shirts" onclick="buyNow('Embroidered Linen Trousers','₹3,990','images/products/f7.jpg',1,'M')">BUY NOW</button>
<a href="#" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Embroidered Linen Trousers','₹3,990','images/products/f7.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
<a href="javascript:void(0)" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Embroidered Linen Trousers','₹3,990','images/products/f7.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
</div>
</div>
</div>
Expand All @@ -510,7 +510,7 @@ <h5>Cat Print Long Sleeve Blouse</h5>
<h4>&#8377;2,699</h4>
<div class="pro-action-bar">
<button class="pro-buy-btn" aria-label="Buy Cartoon Astronaut T-Shirts" onclick="buyNow('Cat Print Long Sleeve Blouse','₹2,699','images/products/f8.jpg',1,'M')">BUY NOW</button>
<a href="#" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Cat Print Long Sleeve Blouse','₹2,699','images/products/f8.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
<a href="javascript:void(0)" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Cat Print Long Sleeve Blouse','₹2,699','images/products/f8.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
</div>
</div>
</div>
Expand Down Expand Up @@ -541,7 +541,7 @@ <h5>Sky Blue Mandarin Collar Shirt</h5>
<h4>&#8377;4,499</h4>
<div class="pro-action-bar">
<button class="pro-buy-btn" aria-label="Buy Cartoon Astronaut T-Shirts" onclick="buyNow('Sky Blue Mandarin Collar Shirt','₹4,499','images/products/n1.jpg',1,'M')">BUY NOW</button>
<a href="#" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Sky Blue Mandarin Collar Shirt','₹4,499','images/products/n1.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
<a href="javascript:void(0)" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Sky Blue Mandarin Collar Shirt','₹4,499','images/products/n1.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
</div>
</div>
</div>
Expand All @@ -558,7 +558,7 @@ <h5>Navy Textured Formal Shirt</h5>
<h4>&#8377;6,999</h4>
<div class="pro-action-bar">
<button class="pro-buy-btn" aria-label="Buy Cartoon Astronaut T-Shirts" onclick="buyNow('Navy Textured Formal Shirt','₹6,999','images/products/n2.jpg',1,'M')">BUY NOW</button>
<a href="#" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Navy Textured Formal Shirt','₹6,999','images/products/n2.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
<a href="javascript:void(0)" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Navy Textured Formal Shirt','₹6,999','images/products/n2.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
</div>
</div>
</div>
Expand All @@ -575,7 +575,7 @@ <h5>Classic White Cotton Shirt</h5>
<h4>&#8377;5,499</h4>
<div class="pro-action-bar">
<button class="pro-buy-btn" aria-label="Buy Cartoon Astronaut T-Shirts" onclick="buyNow('Classic White Cotton Shirt','₹5,499','images/products/n3.jpg',1,'M')">BUY NOW</button>
<a href="#" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Classic White Cotton Shirt','₹5,499','images/products/n3.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
<a href="javascript:void(0)" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Classic White Cotton Shirt','₹5,499','images/products/n3.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
</div>
</div>

Expand Down Expand Up @@ -653,7 +653,7 @@ <h5>Sandstone Tactical Utility Shirt</h5>
<h4>&#8377;3,990</h4>
<div class="pro-action-bar">
<button class="pro-buy-btn" aria-label="Buy Cartoon Astronaut T-Shirts" onclick="buyNow('Sandstone Tactical Utility Shirt','₹3,990','images/products/n4.jpg',1,'M')">BUY NOW</button>
<a href="#" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Sandstone Tactical Utility Shirt','₹3,990','images/products/n4.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
<a href="javascript:void(0)" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Sandstone Tactical Utility Shirt','₹3,990','images/products/n4.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
</div>
</div>
</div>
Expand All @@ -670,7 +670,7 @@ <h5>Denim Blue Everyday Shirt</h5>
<h4>&#8377;2,799</h4>
<div class="pro-action-bar">
<button class="pro-buy-btn" aria-label="Buy Cartoon Astronaut T-Shirts" onclick="buyNow('Denim Blue Everyday Shirt','₹2,799','images/products/n5.jpg',1,'M')">BUY NOW</button>
<a href="#" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Denim Blue Everyday Shirt','₹2,799','images/products/n5.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
<a href="javascript:void(0)" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Denim Blue Everyday Shirt','₹2,799','images/products/n5.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
</div>
</div>
</div>
Expand All @@ -687,7 +687,7 @@ <h5>Vertical Stripe Chino Shorts</h5>
<h4>&#8377;2,499</h4>
<div class="pro-action-bar">
<button class="pro-buy-btn" aria-label="Buy Cartoon Astronaut T-Shirts" onclick="buyNow('Vertical Stripe Chino Shorts','₹2,499','images/products/n6.jpg',1,'M')">BUY NOW</button>
<a href="#" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Vertical Stripe Chino Shorts','₹2,499','images/products/n6.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
<a href="javascript:void(0)" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Vertical Stripe Chino Shorts','₹2,499','images/products/n6.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
</div>
</div>
</div>
Expand All @@ -704,7 +704,7 @@ <h5>Khaki Safari Work Shirt</h5>
<h4>&#8377;3,499</h4>
<div class="pro-action-bar">
<button class="pro-buy-btn" aria-label="Buy Cartoon Astronaut T-Shirts" onclick="buyNow('Khaki Safari Work Shirt','₹3,499','images/products/n7.jpg',1,'M')">BUY NOW</button>
<a href="#" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Khaki Safari Work Shirt','₹3,499','images/products/n7.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
<a href="javascript:void(0)" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Khaki Safari Work Shirt','₹3,499','images/products/n7.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
</div>
</div>
</div>
Expand All @@ -721,7 +721,7 @@ <h5>Deep Charcoal Casual Shirt</h5>
<h4>&#8377;1,799</h4>
<div class="pro-action-bar">
<button class="pro-buy-btn" aria-label="Buy Cartoon Astronaut T-Shirts" onclick="buyNow('Deep Charcoal Casual Shirt','₹1,799','images/products/n8.jpg',1,'M')">BUY NOW</button>
<a href="#" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Deep Charcoal Casual Shirt','₹1,799','images/products/n8.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
<a href="javascript:void(0)" class="pro-cart-btn" aria-label="Add to cart" onclick="event.stopPropagation();addToCart('Deep Charcoal Casual Shirt','₹1,799','images/products/n8.jpg',1,'M');return false;"><i class="ri-shopping-cart-2-line"></i></a>
</div>
</div>
</div>
Expand Down Expand Up @@ -809,7 +809,7 @@ <h4>About</h4>
<h4>My Account</h4>
<a href="login.html">Sign In</a>
<a href="cart.html">View Cart</a>
<a href="#">My Wishlist</a>
<a href="javascript:void(0)">My Wishlist</a>
<a href="cart.html">Track My Order</a>
<a href="contact.html">Help</a>
</div>
Expand Down
4 changes: 2 additions & 2 deletions shop.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
</li>
<li class="nav-icon"><a href="cart.html" id="lg-bag" aria-label="Cart"><i class="ri-shopping-bag-4-line"></i></a></li>
<li class="nav-icon"><button class="theme-toggle" id="themeToggle" aria-label="Toggle dark mode"><i class="ri-moon-line" id="themeIcon"></i></button></li>
<a href="#" id="close" aria-label="Close menu"><i class="fa-solid fa-xmark"></i></a>
<a href="javascript:void(0)" id="close" aria-label="Close menu"><i class="fa-solid fa-xmark"></i></a>
</ul>
</div>
<div class="mobile">
Expand Down Expand Up @@ -296,7 +296,7 @@ <h4>About</h4>
<h4>My Account</h4>
<a href="login.html">Sign In</a>
<a href="cart.html">View Cart</a>
<a href="#">My Wishlist</a>
<a href="javascript:void(0)">My Wishlist</a>
<a href="cart.html">Track My Order</a>
<a href="contact.html">Help</a>
</div>
Expand Down
Loading