fix(ui): replace dead href links with javascript:void(0)#2258
Open
Prateek2007-cmd wants to merge 1 commit into
Open
fix(ui): replace dead href links with javascript:void(0)#2258Prateek2007-cmd wants to merge 1 commit into
Prateek2007-cmd wants to merge 1 commit into
Conversation
|
@Prateek2007-cmd is attempting to deploy a commit to the janavipandole's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves Issue 6: Widespread Dead Links (
href="#").Closes #2252
Numerous interactive elements (like cart buttons, wishlist placeholders, and the mobile menu close button) were using
href="#". Clicking these dead links inherently causes the browser to jump back to the top of the page, disrupting the user experience and negatively impacting SEO.This PR replaces these placeholder links with
href="javascript:void(0)"across the primary entry-point views (index.html,shop.html, andcart.html). This ensures the UI buttons remain clickable without triggering unwanted navigation or scrolling behavior.Changes Made
index.html,shop.html, andcart.htmlby globally replacinghref="#"withhref="javascript:void(0)".Type of Change