Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodename #171

Closed
wants to merge 4 commits into from
Closed

Nodename #171

wants to merge 4 commits into from

Conversation

erikvveen
Copy link

No description provided.

erikvveen
erikvveen commented Dec 24, 2024
View reviewed changes
Copy link
Author

@erikvveen erikvveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodename moet format volgen voor AWS CCM

PhilipSchmid
PhilipSchmid requested changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@PhilipSchmid PhilipSchmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

A few things I'd like to address before merging this:

  1. Please run terraform fmt
  2. Please update the READMD.md TF doc by running make docs
  3. Squash the two commits into a single one and add a proper commit message.

Thanks!

00-variables.tf Outdated
description = "IAM instance profile to attach to the instances."
type = string
default = null

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@PhilipSchmid PhilipSchmid mentioned this pull request Jan 6, 2025
Open
@erikvveen
Copy link
Author

Obsolete by #173

@erikvveen erikvveen closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipSchmid PhilipSchmid PhilipSchmid requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikvveen @PhilipSchmid