Talos k8s with AWS CCM support #173
Conversation
…ntroller nodes and CNI Cilium.exclusive=true (should be "false")
| }, | ||
| controllerManager = { | ||
| extraArgs = { | ||
| allocate-node-cidrs = var.allocate_node_cidrs | ||
| cloud-provider = "external" | ||
| leader-elect = true |
There was a problem hiding this comment.
| leader-elect = true |
This should already be the default, according to https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/.
| module.elb_k8s_elb.elb_dns_name | ||
| ] | ||
| extraArgs = { | ||
| cloud-provider = "external" |
There was a problem hiding this comment.
| cloud-provider = "external" |
kube-apiserver doesn't have a cloud-provider extraArg, according to https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/.
| }, | ||
| certSANs = [ | ||
| module.elb_k8s_elb.elb_dns_name, | ||
| ] |
There was a problem hiding this comment.
Please fix the formatting
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| # Used to configure Cilium Kube-Proxy replacement | ||
|
|
|
|
||
|
|
||
|
|
||
| config_patches_common = [ |
| @@ -32,7 +34,9 @@ module "talos_worker_group" { | |||
| subnet_id = element(data.aws_subnets.public.ids, tonumber(trimprefix(each.key, "${each.value.name}."))) | |||
| associate_public_ip_address = true | |||
| tags = merge(each.value.tags, var.tags, local.cluster_required_tags) | |||
|
|
|||
| metadata_options = var.metadata_options | |||
There was a problem hiding this comment.
Remove this change, as it's already covered in your other PR: #171
| @@ -45,18 +49,32 @@ module "talos_worker_group" { | |||
| resource "talos_machine_secrets" "this" {} | |||
|
|
|||
| data "talos_machine_configuration" "controlplane" { | |||
| count = var.controlplane_count | |||
There was a problem hiding this comment.
Could we iterate via the same method (for_each) as for the worker_group talos_machine_configuration?
| } | ||
|
|
||
| resource "talos_machine_configuration_apply" "controlplane" { | ||
| count = var.controlplane_count | ||
|
|
||
There was a problem hiding this comment.
Remove spaces from all empty lines
| @@ -106,6 +137,7 @@ data "talos_client_configuration" "this" { | |||
| cluster_name = var.cluster_name | |||
| client_configuration = talos_machine_secrets.this.client_configuration | |||
| endpoints = module.talos_control_plane_nodes.*.public_ip | |||
| nodes = module.talos_control_plane_nodes.*.private_ip | |||
There was a problem hiding this comment.
Where does this come from? I don't see it in https://registry.terraform.io/providers/siderolabs/talos/0.7.0/docs/resources/machine_bootstrap. Same for endpoints (which was already there).
| ] | ||
| extraArgs = { | ||
| cloud-provider = "external" | ||
| enable-admission-plugins = "MutatingAdmissionWebhook,ValidatingAdmissionWebhook, ServiceAccount" |
There was a problem hiding this comment.
| enable-admission-plugins = "MutatingAdmissionWebhook,ValidatingAdmissionWebhook, ServiceAccount" | |
| enable-admission-plugins = "MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ServiceAccount" |
& please make that configurable.
No description provided.