feat: show all protocols in connectivity #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <[email protected]>
|
FYI noticed interesting edge case with js-ipfs in Brave: Personally, I think it is the right way to display this type of edge case. There is no length or nesting limit, so truncating is expected. Ellipsis hints uses to hover and when #1169 lands the full multiaddr will be displayed which is what I would expect from this type of UI. In other words, no blocker here, ok to merge. |
|
Thanks for the review @lidel. I also prefer this one. Hence, I am merging it! |
This was referenced Sep 19, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1141. Shows all protocols in the connectivity column. This is an alternative for #1166. Only one must be merged.
License: MIT
Signed-off-by: Henrique Dias [email protected]