Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'ws' and 'wss' to peer connectivity #1166

Closed
wants to merge 1 commit into from

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Sep 15, 2019

Fixes #1141. Adds 'ws' and 'wss' on WebSockets connectivities. This is an alternative for #1167. Only one must be merged.

image

License: MIT
Signed-off-by: Henrique Dias [email protected]

License: MIT
Signed-off-by: Henrique Dias <[email protected]>
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with the other PR instead.
Rationale in #1167 (review)

@hacdias hacdias closed this Sep 19, 2019
@hacdias hacdias deleted the feat/show-ws-wss branch September 19, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Peers: WebSockets transport displayed as TCP
2 participants