chore: center top menu #134
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoblersTune
reviewed
Oct 20, 2025
| display: grid; | ||
| grid-template-columns: minmax(10em, 1fr) 1fr 1fr; | ||
| /* the 123px below: ~ the width of the language switcher, so that menu is centered */ | ||
| grid-template-columns: 10em 1fr calc(10em - 123px); |
Collaborator
There was a problem hiding this comment.
Let's avoid "magic numbers". It's always better practice to put a value in a variable and name it. Then when people look at it in the future they can see what this value represents.
I tried explicitly setting the width on the language switcher to 123px and it breaks. Keep in mind the width value changes as the screen size changes, it causes the text size to change since our fonts are set to be smoothly responsive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Summary
Center the top menu on foundation website