Skip to content

chore: center top menu #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: center top menu #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web/themes/interledger/css/navigation.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,8 @@
.site-links-wrapper {
grid-area: 1 / 1 / 2 / 4;
display: grid;
grid-template-columns: minmax(10em, 1fr) 1fr 1fr;
/* the 123px below: ~ the width of the language switcher, so that menu is centered */
grid-template-columns: 10em 1fr calc(10em - 123px);
Copy link
Collaborator

@JoblersTune JoblersTune Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's avoid "magic numbers". It's always better practice to put a value in a variable and name it. Then when people look at it in the future they can see what this value represents.

I tried explicitly setting the width on the language switcher to 123px and it breaks. Keep in mind the width value changes as the screen size changes, it causes the text size to change since our fonts are set to be smoothly responsive.

grid-template-areas: ". menu site";
gap: var(--space-s);
}
Expand Down
2 changes: 1 addition & 1 deletion web/themes/interledger/interledger.libraries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
global-styling:
version: 1.5.2
version: 1.5.3
css:
theme:
css/fonts.css: {}
Expand Down