Fixes TealAppDriver & implement regression tests#1559
Merged
Conversation
averissimo
force-pushed
the
1535-regression
branch
from
July 14, 2025 11:55
a4d85aa to
8ba4976
Compare
averissimo
changed the title
…id will be variable)
averissimo
marked this pull request as ready for review
July 17, 2025 07:56
Contributor
Unit Tests Summary 1 files 25 suites 2m 6s ⏱️ Results for commit a831f25. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance Difference
Additional test case details
Results for commit d589554 ♻️ This comment has been updated with latest results. |
Contributor
|
I checked the tests added and I only found 2 bslib regression tests added about collapsing the data summary and the filters panel (no one about collapsing filters of an individual dataset). Not sure if we need to test for other things that might be tested on teal.slice but are modified by teal or some that are teal exclusive regarding bslib. |
Co-authored-by: Lluís Revilla <185338939+llrs-roche@users.noreply.github.com> Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
llrs-roche
approved these changes
Jul 23, 2025
llrs-roche
left a comment
llrs-roche
left a comment
Contributor
There was a problem hiding this comment.
Great work! Two very minor suggestions.
Given that insightsengineering/teal.slice#653 hasn't merged perhaps we should wait to merge but I give it the green light
averissimo
commented
Jul 23, 2025
…pkgs in framework
Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com> Signed-off-by: Vedha Viyash <49812166+vedhav@users.noreply.github.com>
…ession * origin/fix-test-ns@main: empty: trigger ci [skip style] [skip vbump] Restyle files Update R/TealAppDriver.R fix: make sure we assign the proper tab namespace based on the href
averissimo
enabled auto-merge (squash)
July 24, 2025 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Fixes #1535
Changes description
testthat::skip("chromium")from e2e tests