Standardize the modal buttons

[vedhav]

Part of our effort to have same modals across the whole framework. (teal.reporter modals are changed in this PR: insightsengineering/teal.reporter#361)
We agreed to have the main action as a primary button and the dismiss button to close the modal.

[github-actions]

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  --------------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            87      87  0.00%    4-163
R/get_dt_rows.R                  13      13  0.00%    44-56
R/ggplot2_args.R                 49       0  100.00%
R/nested_closeable_modal.R       16      16  0.00%    83-98
R/optionalInput.R               255     212  16.86%   140-438, 501, 562, 568, 583-596
R/panel_group.R                  39      39  0.00%    50-136
R/plot_with_settings.R          309      16  94.82%   299-305, 327, 364, 373-374, 390, 578-579, 581, 583
R/standard_layout.R              52      20  61.54%   81-99, 106
R/table_with_settings.R         158       1  99.37%   100
R/utils.R                         7       0  100.00%
R/verbatim_popup.R              107      52  51.40%   75-90, 116-117, 119, 127-158, 179
R/white_small_well.R              7       7  0.00%    19-25
TOTAL                          1122     463  58.73%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  -------
R/verbatim_popup.R       +2      +2  -0.98%
TOTAL                    +2      +2  -0.10%

Results for commit: 9aea6b1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

  1 files   16 suites   7s ⏱️
122 tests  97 ✅ 25 💤 0 ❌
217 runs  192 ✅ 25 💤 0 ❌

Results for commit 9aea6b1.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
draggable_buckets_ui	💔	$0.04$	$+3.23$	$+1$	$-1$	$0$	$0$
get_dt_rows_ui	💔	$0.07$	$+2.82$	$+4$	$-1$	$0$	$0$
nested_closeable_modal_ui	💔	$0.01$	$+2.83$	$+5$	$-1$	$0$	$0$
optionalSelectInput_ui	💔	$0.01$	$+6.87$	$+12$	$-1$	$0$	$+1$
optionalSliderInputValMinMax_ui	💔	$0.01$	$+2.48$	$+1$	$-1$	$0$	$0$
plot_with_settings_ui	💔	$0.18$	$+50.33$	$+30$	$-11$	$0$	$0$
table_with_settings_ui	💔	$0.13$	$+32.43$	$+47$	$-8$	$0$	$0$
verbatim_popup_ui	💔	$0.02$	$+3.47$	$+5$	$-1$	$+1$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
draggable_buckets_ui	💔	$0.04$	$+3.23$	e2e_teal.widgets_draggable_buckets_initializes
get_dt_rows_ui	💔	$0.07$	$+2.82$	e2e_teal.widgets_get_dt_rows_rows_are_settable_and_visible
nested_closeable_modal_ui	💔	$0.01$	$+2.83$	e2e_teal.widgets_nested_closeable_modal_initializes
optionalSelectInput_ui	💔	$0.01$	$+6.87$	e2e_teal.widgets_optionalSelectInput_initializes
optionalSliderInputValMinMax_ui	💔	$0.01$	$+2.48$	e2e_teal.widgets_optionalSliderInputValMinMax_initializes
plot_with_settings_ui	💔	$0.03$	$+4.24$	e2e_teal.widgets_plot_with_settings_buttons_have_proper_FA_icons_and_two_of_them_are_dropdowns
plot_with_settings_ui	💔	$0.01$	$+3.95$	e2e_teal.widgets_plot_with_settings_clicking_download_download_button_downloads_image_in_a_specified_format
plot_with_settings_ui	💔	$0.01$	$+4.76$	e2e_teal.widgets_plot_with_settings_expanded_image_can_be_downloaded
plot_with_settings_ui	💔	$0.01$	$+7.83$	e2e_teal.widgets_plot_with_settings_expanded_image_can_be_resized
plot_with_settings_ui	💔	$0.00$	$+3.21$	e2e_teal.widgets_plot_with_settings_initializes_with_a_plot_and_the_settings_buttons
plot_with_settings_ui	💔	$0.01$	$+3.25$	e2e_teal.widgets_plot_with_settings_it_is_possible_to_set_height_and_width_for_the_plot_on_the_third_button_dropdown_menu_without_errors
plot_with_settings_ui	💔	$0.01$	$+4.59$	e2e_teal.widgets_plot_with_settings_main_image_can_be_resized
plot_with_settings_ui	💔	$0.01$	$+5.20$	e2e_teal.widgets_plot_with_settings_scrollbar_appears_when_image_is_resized
plot_with_settings_ui	💔	$0.01$	$+4.60$	e2e_teal.widgets_plot_with_settings_the_click_on_the_download_button_in_expand_modal_opens_a_download_dropdown
plot_with_settings_ui	💔	$0.02$	$+4.23$	e2e_teal.widgets_plot_with_settings_the_click_on_the_expand_button_opens_an_overlay_plot_height_plot_width_plot_download_dropdown_and_dismiss_button
plot_with_settings_ui	💔	$0.02$	$+4.49$	e2e_teal.widgets_plot_with_settings_the_click_on_the_resize_button_opens_a_dropdown_menu_plot_height_plot_width_plot_download_dropdown_and_dismiss_button
table_with_settings_ui	💔	$0.01$	$+4.36$	e2e_teal.widgets_table_with_settings_check_pagination_appearance_for_.txt_and_disappearance_for_.csv_for_the_first_button
table_with_settings_ui	💔	$0.02$	$+4.24$	e2e_teal.widgets_table_with_settings_check_pagination_appearance_for_.txt_and_disappearance_for_.csv_for_the_modal_on_the_second_button
table_with_settings_ui	💔	$0.01$	$+3.80$	e2e_teal.widgets_table_with_settings_clicking_download_download_button_downloads_table_in_a_specified_format
table_with_settings_ui	💔	$0.01$	$+4.49$	e2e_teal.widgets_table_with_settings_clicking_download_in_an_expand_modal_opens_dropdown_menu_with_dwnl_settings_such_as_file_type_file_name_pagination
table_with_settings_ui	💔	$0.01$	$+4.39$	e2e_teal.widgets_table_with_settings_expanded_table_can_be_downloaded
table_with_settings_ui	💔	$0.00$	$+3.02$	e2e_teal.widgets_table_with_settings_is_initialized_with_2_buttons_and_a_table
table_with_settings_ui	💔	$0.01$	$+4.15$	e2e_teal.widgets_table_with_settings_the_click_on_expand_button_opens_a_modal_with_a_table
table_with_settings_ui	💔	$0.01$	$+4.00$	e2e_teal.widgets_table_with_settings_the_click_on_the_download_button_opens_a_download_menu_with_file_type_file_name_and_download_button
verbatim_popup_ui	💔	$0.00$	$+3.48$	e2e_teal.widgets_verbatim_popup_is_initialized_with_a_button_that_opens_a_modal_with_a_verbatim_text

Results for commit c46a995

♻️ This comment has been updated with latest results.

[averissimo]

Looking good!