Skip to content

replace summarise with reframe #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangben718 wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

replace summarise with reframe #1014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dea5fc3
replace summarise with reframe
wangben718 Aug 12, 2026
87ffed3
[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
github-actions[bot] Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ Config/Needs/verdepcheck: haleyjeppson/ggmosaic, tidyverse/ggplot2,
tidyverse/rvest, htmlwidgets/sparkline, rstudio/shinytest2,
r-lib/testthat, r-lib/withr
Config/Needs/website: insightsengineering/nesttemplate
Config/roxygen2/version: 8.0.0
Config/roxygen2/version: 8.1.0
Encoding: UTF-8
Language: en-US
Roxygen: list(markdown = TRUE, packages = c("roxy.shinylive"))
2 changes: 1 addition & 1 deletion R/tm_missing_data.R
View file
Open in desktop

@averissimo averissimo Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update NEWS.md with this change!

I guess the the DESCRIPTION file can stay as is, as the problem actually starts from 1.1.0

@averissimo averissimo Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve once the NEWS.md is updated

Original file line number Diff line number Diff line change
Expand Up @@ -1322,7 +1322,7 @@ srv_missing_data <- function(id,
# order columns by decreasing percent of missing values
ordered_columns <- summary_plot_patients %>%
dplyr::select(-"id", -dplyr::all_of(parent_keys)) %>%
dplyr::summarise(
dplyr::reframe(
column = create_cols_labels(colnames(.)),
na_count = apply(., MARGIN = 2, FUN = sum),
na_percent = na_count / nrow(.) * 100
Expand Down
Loading