Skip to content

replace summarise with reframe - #1014

Open
wangben718 wants to merge 2 commits into
mainfrom
1013-bug-tm_missing_data-grouped-by-subject-fails-with-dplyr-11-must-be-size-1
Open

replace summarise with reframe#1014
wangben718 wants to merge 2 commits into
mainfrom
1013-bug-tm_missing_data-grouped-by-subject-fails-with-dplyr-11-must-be-size-1

Conversation

@wangben718

Copy link
Copy Markdown

Fixes #1013

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Unit Tests Summary

    1 files     56 suites   45m 28s ⏱️
  979 tests   977 ✅ 2 💤 0 ❌
1 950 runs  1 948 ✅ 2 💤 0 ❌

Results for commit 87ffed3.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_pca 💚 $234.95$ $-10.62$ $0$ $0$ $0$ $0$
shinytest2-tm_a_pca_picks 💚 $284.00$ $-9.49$ $0$ $0$ $0$ $0$
shinytest2-tm_a_regression 💚 $94.77$ $-4.60$ $0$ $0$ $0$ $0$
shinytest2-tm_a_regression_picks 💚 $91.28$ $-5.06$ $0$ $0$ $0$ $0$
shinytest2-tm_data_table 💚 $39.28$ $-2.89$ $0$ $0$ $0$ $0$
shinytest2-tm_file_viewer 💚 $46.48$ $-2.16$ $0$ $0$ $0$ $0$
shinytest2-tm_front_page 💚 $34.74$ $-1.87$ $0$ $0$ $0$ $0$
shinytest2-tm_g_association 💚 $50.09$ $-3.28$ $0$ $0$ $0$ $0$
shinytest2-tm_g_association_picks 💚 $54.75$ $-2.90$ $0$ $0$ $0$ $0$
shinytest2-tm_g_bivariate 💚 $109.27$ $-6.13$ $0$ $0$ $0$ $0$
shinytest2-tm_g_bivariate_picks 💚 $175.92$ $-6.67$ $0$ $0$ $0$ $0$
shinytest2-tm_g_distribution 💚 $120.81$ $-3.13$ $0$ $0$ $0$ $0$
shinytest2-tm_g_distribution_picks 💚 $54.12$ $-2.59$ $0$ $0$ $0$ $0$
shinytest2-tm_g_response 💚 $51.93$ $-2.41$ $0$ $0$ $0$ $0$
shinytest2-tm_g_response_picks 💚 $53.81$ $-3.01$ $0$ $0$ $0$ $0$
shinytest2-tm_g_scatterplot 💚 $143.74$ $-4.12$ $0$ $0$ $0$ $0$
shinytest2-tm_g_scatterplot_picks 💚 $144.79$ $-2.06$ $0$ $0$ $0$ $0$
shinytest2-tm_g_scatterplotmatrix 💚 $70.25$ $-2.52$ $0$ $0$ $0$ $0$
shinytest2-tm_outliers 💚 $184.89$ $-6.28$ $0$ $0$ $0$ $0$
shinytest2-tm_t_crosstable 💚 $52.83$ $-1.40$ $0$ $0$ $0$ $0$
shinytest2-tm_variable_browser 💚 $105.88$ $-3.03$ $0$ $0$ $0$ $0$
tm_a_pca 💚 $17.43$ $-1.28$ $0$ $0$ $0$ $0$
tm_a_regression 💚 $8.97$ $-1.07$ $0$ $0$ $0$ $0$
tm_g_association 💚 $13.71$ $-1.12$ $0$ $0$ $0$ $0$
tm_g_bivariate_picks 💚 $19.59$ $-1.62$ $0$ $0$ $0$ $0$
tm_g_distribution 💚 $22.05$ $-2.53$ $0$ $0$ $0$ $0$
tm_g_distribution_picks 💚 $18.58$ $-1.17$ $0$ $0$ $0$ $0$
tm_g_response_picks 💚 $8.42$ $-1.59$ $0$ $0$ $0$ $0$
tm_outliers 💚 $55.69$ $-3.24$ $0$ $0$ $0$ $0$
tm_variable_browser 💚 $72.96$ $-4.11$ $0$ $0$ $0$ $0$
utils 💔 $12.47$ $+1.06$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_a_pca 💚 $16.84$ $-1.02$ e2e_tm_a_pca_Changing_output_encodings_for_plot_type_does_not_generate_errors.
shinytest2-tm_a_pca 💚 $74.81$ $-1.13$ e2e_tm_a_pca_Changing_output_encodings_of_font_size_does_not_generate_errors.
shinytest2-tm_a_pca 💚 $35.72$ $-1.24$ e2e_tm_a_pca_Changing_output_encodings_of_plot_type_hides_and_shows_options.
shinytest2-tm_a_pca 💚 $16.19$ $-1.08$ e2e_tm_a_pca_Changing_output_encodings_of_standardization_does_not_generate_errors.
shinytest2-tm_a_pca 💚 $12.38$ $-1.14$ e2e_tm_a_pca_Changing_output_encodings_of_tables_display_does_not_generate_errors.
shinytest2-tm_a_pca 💚 $15.63$ $-1.23$ e2e_tm_a_pca_Color_by_columns_data_extract_must_be_from_non_selected_variable_set.
shinytest2-tm_a_pca 💚 $15.13$ $-1.02$ e2e_tm_a_pca_Eigenvector_table_should_have_data_extract_selection_Murder_UrbanPop_on_header.
shinytest2-tm_a_pca_picks 💚 $16.49$ $-1.01$ e2e_tm_a_pca_Changing_output_encodings_for_plot_type_does_not_generate_errors.
shinytest2-tm_a_pca_picks 💚 $34.73$ $-1.29$ e2e_tm_a_pca_Changing_output_encodings_of_plot_type_hides_and_shows_options.
shinytest2-tm_a_pca_picks 💚 $15.37$ $-1.12$ e2e_tm_a_pca_Changing_output_encodings_of_standardization_does_not_generate_errors.
shinytest2-tm_a_regression 💚 $21.11$ $-1.07$ e2e_tm_a_regression_Plot_type_has_7_specific_choices_changing_choices_does_not_throw_errors.
shinytest2-tm_a_regression_picks 💚 $18.98$ $-1.13$ e2e_tm_a_regression_Plot_type_has_7_specific_choices_changing_choices_does_not_throw_errors.
shinytest2-tm_g_association 💚 $13.37$ $-1.06$ e2e_tm_g_association_Data_extract_spec_elements_are_initialized_with_the_default_values_specified_by_ref_and_vars_arguments.
shinytest2-tm_g_bivariate 💚 $42.47$ $-3.92$ e2e_tm_g_bivariate_Setting_encoding_inputs_produces_outputs_without_validation_errors.
shinytest2-tm_g_bivariate_picks 💚 $79.05$ $-1.43$ e2e_tm_g_bivariate_Module_is_initialised_with_the_specified_defaults.
shinytest2-tm_g_bivariate_picks 💚 $43.06$ $-3.66$ e2e_tm_g_bivariate_Setting_encoding_inputs_produces_outputs_without_validation_errors.
shinytest2-tm_g_distribution 💚 $25.62$ $-1.30$ e2e_tm_g_distribution_Histogram_encoding_inputs_produce_output_without_validation_errors.
shinytest2-tm_g_distribution 💚 $79.30$ $-1.29$ e2e_tm_g_distribution_Module_is_initialised_with_the_specified_defaults.
shinytest2-tm_g_distribution_picks 💚 $26.25$ $-1.45$ e2e_tm_g_distribution_Histogram_encoding_inputs_produce_output_without_validation_errors.
shinytest2-tm_g_response_picks 💚 $20.50$ $-1.18$ e2e_tm_g_response_encoding_inputs_produce_output_without_validation_errors.
shinytest2-tm_g_scatterplot 💚 $91.33$ $-1.61$ e2e_tm_g_scatterplot_The_encoding_inputs_are_set_without_validation_errors.
shinytest2-tm_g_scatterplotmatrix_picks 💔 $21.52$ $+1.18$ e2e_tm_g_scatterplotmatrix_Change_plot_settings
shinytest2-tm_outliers 💚 $35.79$ $-1.78$ e2e_tm_outliers_Outlier_definition_text_and_range_are_displayed_properly_depending_on_method.
shinytest2-tm_variable_browser 💚 $23.50$ $-1.04$ e2e_tm_variable_browser_changing_plot_setting_encodings_doesn_t_show_errors.
tm_variable_browser 💚 $12.93$ $-2.08$ UI_switches_and_controls_server_handles_different_outlier_definition_thresholds

Results for commit 2fde6d1

♻️ This comment has been updated with latest results.

@averissimo averissimo self-assigned this Aug 13, 2026
Comment thread R/tm_missing_data.R

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update NEWS.md with this change!

I guess the the DESCRIPTION file can stay as is, as the problem actually starts from 1.1.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve once the NEWS.md is updated

@averissimo

Copy link
Copy Markdown
Contributor

@wangben718 please follow the instructions from the CLA bot.

You only have to do this once per repository, but it's needed

@wangben718

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: tm_missing_data() "Grouped by Subject" fails with dplyr ≥ 1.1: "must be size 1"

2 participants