Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md send #72

Closed
wants to merge 1 commit into from
Closed

Update README.md send #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ See below, a simple example of sending a single SMS message to a single recipien
content: new SmsTextContent(
text: 'This is a dummy SMS message sent using infobip-api-php-client.'
),
sender: 'InfoSMS'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would like to keep our original example sender.

sender: 'BankElithad'
);

$request = new SmsRequest(messages: [$message]);
Expand Down Expand Up @@ -208,7 +208,7 @@ Example of webhook implementation:
*/
$messages = $objectSerializer->deserialize($data, SmsInboundMessageResult::class);

foreach ($messages->getResults() ?? [] as $message) {
for each ($messages->getResults() ?? [] as $message) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct PHP syntax is foreach: https://www.php.net/manual/en/control-structures.foreach.php.

echo $message-> getFrom() . " - " . $message-> getCleanText() . "\n";
}
```
Expand All @@ -217,22 +217,22 @@ Example of webhook implementation:
For 2FA quick start guide please check [these examples](two-factor-authentication.md).

#### Send email
For send email quick start guide please check [these examples](email.md).
For sending email quick start guide please check [these examples](email.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will review the README grammar one more time on our side. Thank you very much for your suggestions!


#### WhatsApp
For WhatsApp quick start guide, view [these examples](whatsapp.md).
For the WhatsApp quick start guide, please take a look at these examples](WhatsApp.md).

#### Messages API
For Messages API quick start guide, view [these examples](messages-api.md).
For Messages API quick start guide, please take a look at [these examples](messages-api.md).

#### Moments
For Moments quick start guide, view [these examples](moments.md).
For Moments quick start guide, please take a look at [these examples](moments.md).

## Ask for help

Feel free to open issues on the repository for any issue or feature request. As per pull requests, for details check the `CONTRIBUTING` [file][contributing] related to it - in short, we will not merge any pull requests, this code is auto-generated.

This code is auto generated, and we are unable to merge any pull request from here, but we will review and implement changes directly within our pipeline, as described in the `CONTRIBUTING` [file][contributing].
This code is auto-generated, and we are unable to merge any pull request from here, but we will review and implement changes directly within our pipeline, as described in the `CONTRIBUTING` [file][contributing].

For anything that requires our imminent attention, contact us @ [[email protected]](mailto:[email protected]).

Expand Down