Update README.md send #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ib-fsrnec
reviewed
Feb 20, 2025
There was a problem hiding this comment.
Hello @yazankhadra and thank you for the pull request. Unfortunately, we are unable to directly accept the suggested changes at this time. Please refer to the individual comments for details. We will certainly review the README grammar and wording on our end once more.
Best regards,
Filip
| @@ -94,7 +94,7 @@ See below, a simple example of sending a single SMS message to a single recipien | |||
| content: new SmsTextContent( | |||
| text: 'This is a dummy SMS message sent using infobip-api-php-client.' | |||
| ), | |||
| sender: 'InfoSMS' | |||
There was a problem hiding this comment.
We would like to keep our original example sender.
| @@ -208,7 +208,7 @@ Example of webhook implementation: | |||
| */ | |||
| $messages = $objectSerializer->deserialize($data, SmsInboundMessageResult::class); | |||
|
|
|||
| foreach ($messages->getResults() ?? [] as $message) { | |||
| for each ($messages->getResults() ?? [] as $message) { | |||
There was a problem hiding this comment.
The correct PHP syntax is foreach: https://www.php.net/manual/en/control-structures.foreach.php.
| @@ -217,22 +217,22 @@ Example of webhook implementation: | |||
| For 2FA quick start guide please check [these examples](two-factor-authentication.md). | |||
|
|
|||
| #### Send email | |||
| For send email quick start guide please check [these examples](email.md). | |||
| For sending email quick start guide please check [these examples](email.md). | |||
There was a problem hiding this comment.
We will review the README grammar one more time on our side. Thank you very much for your suggestions!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.