Skip to content

feat(api): return sandbox IP from start #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WenYuLuo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(api): return sandbox IP from start #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions api/runtime/v1/sandbox-api.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions api/runtime/v1/sandbox-api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,8 @@ message StartResponse {
string message = 2;
// ID is the unique sandbox ID.
string id = 3;
// SandboxIP is the address assigned to the sandbox network endpoint.
string sandbox_ip = 4;
}

// CheckpointRequest describes a synchronous checkpoint operation.
Expand Down
2 changes: 1 addition & 1 deletion api/runtime/v1/sandbox_api_compat_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func TestV010WireContract(t *testing.T) {
// Rolled for StartRequest.inject_entrypoint (field 22), which supplies the
// in-sandbox destination for injected OCI image startup configuration.
// Recompute after any proto change: run this test, copy the got hash.
const want = "5cbcd4bbad5035b8c2d5224e0f08944f38ee0188d5116e09ac8f16ef5419fc6b"
const want = "21eb701d4c16828d5f4ac42d6a50d6f644e038b6b967b4c5165a9dd025aed67b"
if got := hex.EncodeToString(sum[:]); got != want {
t.Fatalf("sandbox API descriptor hash = %s, want %s", got, want)
}
Expand Down
7 changes: 4 additions & 3 deletions internal/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1637,9 +1637,10 @@ func (h *sandboxService) Start(ctx context.Context, request *runtime.StartReques
})
startSucceeded = true
return &runtime.StartResponse{
Code: 0,
Message: "Succeed",
ID: sandboxID,
Code: 0,
Message: "Succeed",
ID: sandboxID,
SandboxIp: preparedResources.sandboxIP,
}, nil
}

Expand Down