Skip to content

feat(api): return sandbox IP from start - #45

Open
WenYuLuo wants to merge 1 commit into
inclusionAI:mainfrom
WenYuLuo:feat/sandbox-ip-gvisor-akernel2
Open

feat(api): return sandbox IP from start#45
WenYuLuo wants to merge 1 commit into
inclusionAI:mainfrom
WenYuLuo:feat/sandbox-ip-gvisor-akernel2

Conversation

@WenYuLuo

@WenYuLuo WenYuLuo commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Return the sandbox network address from StartResponse as sandbox_ip. This lets FunctionSystem publish and retire Node Proxy routes without exposing bridge-specific names or endpoint generation tokens. Port mappings remain caller-owned input in StartRequest and are not echoed in the response.

The branch is rebased on the current main, which already contains the patched gVisor runtime pin.

Interface changes

Adds sandbox_ip = 4 to StartResponse. Port mappings remain in StartRequest and ListSandboxes; StartResponse does not duplicate them.

Validation

  • go test ./api/runtime/v1 ./internal/server
  • generated protobuf descriptor contract updated with the pinned toolchain
  • consumed successfully by openYuanRong Buildkite #182 full X86 build
  • openYuanRong Buildkite #183 passed all 21 jobs with the data plane, sandbox package and Test K8S enabled
  • after review, redundant StartResponse port echoing was removed; the targeted Go API/server tests passed, and the final cross-repository rebuild is deferred as requested

Signed-off-by: robbluo luo1442@gmail.com

Comment thread api/runtime/v1/sandbox-api.proto Outdated
@WenYuLuo
WenYuLuo force-pushed the feat/sandbox-ip-gvisor-akernel2 branch 2 times, most recently from 1b6afb4 to 49f651d Compare September 3, 2026 07:04
Signed-off-by: robbluo <luo1442@gmail.com>
@WenYuLuo
WenYuLuo force-pushed the feat/sandbox-ip-gvisor-akernel2 branch from 49f651d to 418ef5c Compare September 4, 2026 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants