Skip to content
Merged
Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
343 commits
Select commit Hold shift + click to select a range
3ee157c
add sourceTYPE args to test app
May 24, 2023
e9e9b37
attach auth client properly
May 24, 2023
f3a64f0
bump deps to allow for 3.7 usage
May 24, 2023
9e59284
pnpm update, probably temporary
May 24, 2023
9e224f1
add targetStandaloneDestination to do local lock-free processChanges …
May 25, 2023
db7e395
add test script
May 25, 2023
ced7d72
un-mega-join the Changes() queries
May 25, 2023
2d0ca3e
fix using cached briefcase of wrong changeset
May 26, 2023
2a10154
test-app minor fixes for local test
May 30, 2023
79c7583
wip fixing fedguid using queries
May 30, 2023
51256f4
timeline testutils support for relationship state
May 30, 2023
eecaf11
add relationship delete to big branching workflow test
May 30, 2023
ffc270b
fix unused imports
May 30, 2023
74a3d47
Merge remote-tracking branch 'origin/main' into federation-guid-optim…
May 30, 2023
e0e3e9e
Merge remote-tracking branch 'origin/fork-relationship-delete-tests' …
May 30, 2023
f3794da
quick comment out wip query changes
May 30, 2023
50dd7f0
remove undefined state from targetElementId in onExportElement
May 30, 2023
db17ccf
notes about subset equal limitations
May 30, 2023
7c28c1e
add assert for elem deletion synchronization
May 30, 2023
ac2b9be
wip refactor remap deleted
May 30, 2023
bcb8766
fix element deletes
May 30, 2023
cc8ecd3
cleanup and add deleted rel with no fedguids on its source/target elems
May 30, 2023
8be4ad7
add noDetachChangeCache option
May 30, 2023
a86ee6f
don't use fed-guid less elem 1 for sync deleted-provenance relationsh…
MichaelBelousov May 30, 2023
20d6a9d
minor cleanup
MichaelBelousov May 30, 2023
5928efb
attempt at batch handler that I will revert now
MichaelBelousov May 31, 2023
4707e05
fixup: revert batch and rework on rel delete
MichaelBelousov May 31, 2023
f404f24
working on source==provenance optimization for reverse sync
MichaelBelousov May 31, 2023
aa48f97
use an aligned union query to make it easier to read
MichaelBelousov May 31, 2023
7894db4
query alignment fixes and rewrite processing loop
MichaelBelousov May 31, 2023
1d96851
ignore lacking provenance to handle local deletes showing up in chang…
MichaelBelousov May 31, 2023
51fec5d
fix bad negation on noDetachChangeCache
MichaelBelousov May 31, 2023
6c58d8a
more asserts in big branch test
MichaelBelousov May 31, 2023
68a15d4
add bailing out to querying provenance db even without fedguid
MichaelBelousov May 31, 2023
f640c40
working on last-ditch relationship provenance processing
MichaelBelousov May 31, 2023
8fc264b
try using jsonProperties.targetRelInstanceId for simpler query
MichaelBelousov May 31, 2023
8988c16
add literal name for sync.since argument
MichaelBelousov May 31, 2023
f14d6ed
set target scope version in provenance init
MichaelBelousov May 31, 2023
b3fb7da
disable broken eslint indent rule
MichaelBelousov May 31, 2023
a31d44d
working on reverse sync tracking
MichaelBelousov May 31, 2023
1e175f1
handle reverseSyncVersion
MichaelBelousov May 31, 2023
a395aad
cleanup synchronizationVersion, fix branch workflow test changesets
MichaelBelousov May 31, 2023
2f1189e
deprecate passing changeset index directly to process/exportChanges
MichaelBelousov Jun 1, 2023
7f971dc
remove need to have explicit 'since' in timeline test utility
MichaelBelousov Jun 1, 2023
690c998
split the branches to branch off separate master changesets in big ti…
MichaelBelousov Jun 1, 2023
c2f2da9
fix startChangesetIndexOrId type in _tryInitChangesetData
MichaelBelousov Jun 1, 2023
4c99c4a
use an array instead of an object for timeline
MichaelBelousov Jun 1, 2023
29f7387
add post-sync assertions and remove the generic assertion which isn't…
MichaelBelousov Jun 1, 2023
3be290c
add prerelease type test
MichaelBelousov Jun 1, 2023
066a611
working on skipping merge changesets
MichaelBelousov Jun 2, 2023
b9cb0a2
revert events work that this branch was originally based on
MichaelBelousov Jun 2, 2023
9d716d1
add synchronization changeset detection, updating, and clearing
MichaelBelousov Jun 2, 2023
70b722d
only create change summaries for necessary ranges, skipping synchroni…
MichaelBelousov Jun 2, 2023
85fd6e4
fix algo
MichaelBelousov Jun 2, 2023
466cfff
allow initializing ChangedInstanceIds from multi-ranges of changesets
MichaelBelousov Jun 2, 2023
ff19036
propagate changeset range arguments
MichaelBelousov Jun 2, 2023
e986645
fix excluding sync changesets
MichaelBelousov Jun 5, 2023
a0d2270
cleanup, mostly indent rule
MichaelBelousov Jun 5, 2023
13641e9
don't query entire instance and don't query at all if unnecessary in …
MichaelBelousov Jun 5, 2023
31b6c59
working on fixing aspect provenance
MichaelBelousov Jun 5, 2023
670cf26
add fallback query of element provenance
MichaelBelousov Jun 5, 2023
03cbb27
fix bad assert and lack of bindings in query call I just added
MichaelBelousov Jun 5, 2023
70952e8
tweak large scale test
MichaelBelousov Jun 5, 2023
1e4bc39
use separate transformers to apply changes, ignore skipping of 0th ch…
MichaelBelousov Jun 5, 2023
39b4990
remove extraneous logging and test.only
MichaelBelousov Jun 5, 2023
4ff8c36
Merge remote-tracking branch 'origin/main' into federation-guid-optim…
MichaelBelousov Jun 5, 2023
97dd8f9
test-app: don't check only first briefcase in cache
MichaelBelousov Jun 6, 2023
16ff32e
refactor placement transform and intialize transformer in catalog calls
MichaelBelousov Jun 6, 2023
ed03743
add ignoreMissingChangesetsInSynchronizations option
MichaelBelousov Jun 6, 2023
085c182
make test catalog import async initialized
MichaelBelousov Jun 6, 2023
c2dbc25
fix catalog remapping
MichaelBelousov Jun 6, 2023
5ff2314
reimplement detectElementDeletes for older workflows
MichaelBelousov Jun 6, 2023
91e59f0
remove temp release-dev check
MichaelBelousov Jun 6, 2023
9025a97
don't allow empty string to be prerelease prefix
MichaelBelousov Jun 6, 2023
e0f70d8
Version bump [skip actions]
imodeljs-admin Jun 6, 2023
8069422
Fixed an infinite recursion bug when processing changes (#57)
ViliusRuskys Jun 8, 2023
7982a09
Merge remote-tracking branch 'origin/main' into federation-guid-optim…
MichaelBelousov Jun 8, 2023
c96b047
Explicitly track provenance with ExternalSourceAspects when combining…
ViliusRuskys Jun 8, 2023
ace7e8c
Version bump [skip actions]
imodeljs-admin Jun 8, 2023
349058f
Merge branch 'main' into federation-guid-optimization
MichaelBelousov Jun 14, 2023
be6e364
fix merge artifacts
MichaelBelousov Jun 14, 2023
ce8c451
add validate docs step
MichaelBelousov Jun 14, 2023
601143c
Implemented check for aspect identifier being not an id (#87)
KyryloVolotovskyi Jun 28, 2023
e6dc948
Fix element provenance direction in reverse synchronization workflow …
ViliusRuskys Jun 28, 2023
a56be5b
Version bump [skip actions]
imodeljs-admin Jun 28, 2023
84b733b
reverse synchronization test case (#78)
ViliusRuskys Jul 11, 2023
b541aff
Version bump [skip actions]
imodeljs-admin Jul 11, 2023
68f975d
Merge remote-tracking branch 'origin/main' into federation-guid-optim…
Jul 18, 2023
af070ea
v7 lockfile
Jul 18, 2023
b716a0b
remerge lockfile
Jul 19, 2023
35e2c59
reworking process changes to not traverse element trees
Jul 19, 2023
188773d
fix inverted bool
Jul 19, 2023
a717b38
fix glaring error in forEachTrackedElement
Jul 19, 2023
388a222
don't use transformer context after removing hierarchy
Jul 19, 2023
870198e
deprecate resumption api
Jul 19, 2023
b9d30f2
remove no longer necessary printing of itjs dep
Jul 19, 2023
af15c56
fixup: remove usage of .only on test
Jul 19, 2023
a8f9a1d
continued work
Jul 19, 2023
9558905
Revert "continued work"
Jul 19, 2023
0d4f552
Revert "don't use transformer context after removing hierarchy"
Jul 19, 2023
49e30a8
Revert "reworking process changes to not traverse element trees"
Jul 19, 2023
e2b7608
remove optimization that no longer works without lastMod
Jul 19, 2023
11746e7
update numElementsUpdates
Jul 19, 2023
cc13c5a
Element recreation fix refactor (#99)
Jul 24, 2023
046efb7
Version bump [skip actions]
imodeljs-admin Jul 24, 2023
19cb44c
Fed guid opt branch provenance init test (#107)
DanRod1999 Aug 7, 2023
cfd3024
make updateSynchronizationVersion public and add a force option
MichaelBelousov Aug 10, 2023
2611661
fix bad rename
Aug 10, 2023
1019373
also track source's sync changesets during reverse sync (#108)
Aug 10, 2023
d250f84
Version bump [skip actions]
imodeljs-admin Aug 10, 2023
28b3f0d
Reverse synchronize deletes of elements with random ExternalSourceAsp…
ViliusRuskys Sep 8, 2023
7273a94
Version bump [skip actions]
imodeljs-admin Sep 8, 2023
1377c09
Merge remote-tracking branch 'origin/main' into federation-guid-optim…
Sep 13, 2023
b47d581
post merge test fixes
Sep 13, 2023
5e23859
Version bump [skip actions]
imodeljs-admin Sep 13, 2023
06055a0
revert to original behavior of provenance ExternalSourceAspect versio…
Sep 20, 2023
dfbdeee
Version bump [skip actions]
imodeljs-admin Sep 20, 2023
82efbf7
Merge remote-tracking branch 'origin/main' into federation-guid-optim…
Sep 26, 2023
cdee5bb
remove +1 from aspect check in fedguid branch
Sep 26, 2023
d552d2a
Version bump [skip actions]
imodeljs-admin Sep 26, 2023
815afe7
mike processed FIXMEs
Nov 13, 2023
f56af25
pnpm lint
nick4598 Nov 15, 2023
cb15d46
report last db error in branch provenenance init, and better imports
Nov 15, 2023
8e40874
use pathToFileUrl when attaching database
nick4598 Nov 15, 2023
5dabfb8
add FIXME about filtering syncChangesetsToClear
Nov 15, 2023
030da11
Added API for querying provenance info for derived transformer classe…
ViliusRuskys Nov 17, 2023
6d587f3
Handle duplicate code values when updating elements (#124)
ViliusRuskys Nov 17, 2023
7cd1e5c
Version bump [skip actions]
imodeljs-admin Nov 20, 2023
b7a6679
Move aspect processing before any clean up is started in change proce…
mindaugasdirg Nov 27, 2023
02433db
Algo.ts enhancements, test deleting relationship and delete element r…
nick4598 Nov 29, 2023
74333f6
unskip test that we must fix before this merges, now that deployed ve…
Nov 29, 2023
0cc7cfb
Add FIXME about new fed guid behavior on special root elems
Nov 29, 2023
25b9b99
Change the BranchProvenanceInitializer tests so that they don't creat…
nick4598 Dec 8, 2023
799afea
Read changesets directly instead of applying them to determine whats …
nick4598 Jan 12, 2024
187d8be
Add prettier as a commit hook, switch to eslint flat config, add some…
nick4598 Jan 16, 2024
d7925b9
Use options.forceExternalSourceAspectProvenance && shouldDetectDelete…
nick4598 Jan 19, 2024
aa88255
Detect synchronization direction from ESA data stored in the provenan…
nick4598 Jan 25, 2024
f2b4d6c
Allow no versioning data if user opts into it (#146)
nick4598 Feb 23, 2024
ec07856
throw when danglingReferencesBehavior is reject (#150)
nick4598 Feb 23, 2024
ce9364b
Support delete detection in test (#151)
nick4598 Feb 23, 2024
e7ae1f5
Run lint:fix (#152)
nick4598 Feb 23, 2024
c93b84a
save and push changes after transformer is complete (#153)
nick4598 Feb 23, 2024
5b3087c
rootElementPropagateChanges/skipBranchProvInitializeCs (#154)
nick4598 Feb 23, 2024
f8438e9
change version to 1.0.0
nick4598 Feb 27, 2024
e15c103
Version bump [skip actions]
imodeljs-admin Feb 27, 2024
bd1649e
Change files
nick4598 Feb 27, 2024
9dcb464
1.0.0-dev.0
nick4598 Feb 27, 2024
5771a86
try 1.0.0
nick4598 Feb 27, 2024
ee28da0
change package json version back to 0.4.18-fedguidopt.4
nick4598 Feb 27, 2024
0c9600a
Change files
nick4598 Feb 27, 2024
87d0677
Version bump [skip actions]
imodeljs-admin Feb 27, 2024
d3e50c3
Change files
nick4598 Feb 28, 2024
feeed15
1.0.0-dev.0
nick4598 Feb 28, 2024
2d26ba5
Version bump [skip actions]
imodeljs-admin Feb 28, 2024
1f594de
Cleanup some misc fixmes (#156)
nick4598 Feb 28, 2024
99a431b
Slightly change test to make sure an element introduced by branch A c…
nick4598 Mar 7, 2024
a4bea01
Special case root subject remapping (#161)
jiaruiz717 Mar 18, 2024
d216ce5
Filter the changesets as opposed to outright clearing them when the d…
nick4598 Mar 19, 2024
0023687
Check excludedElementIds before we decide to load the element in IMod…
nick4598 Mar 20, 2024
bef4493
Version bump [skip actions]
imodeljs-admin Mar 20, 2024
fdf23e0
Remove pnpm patch and update minimum peerDep to first version which i…
nick4598 Mar 26, 2024
63d18ce
Version bump [skip actions]
imodeljs-admin Mar 26, 2024
7d38d53
Merge main into fed guid optimization (#166)
nick4598 Apr 12, 2024
1ed2966
Version bump [skip actions]
imodeljs-admin Apr 12, 2024
336227e
Merge remote-tracking branch 'origin/main' into federation-guid-optim…
nick4598 Apr 12, 2024
e86ddcb
Fix ALL lint errors and remove deprecated danglingPredecessorsBehavio…
nick4598 Apr 15, 2024
898cc20
FIX the rest of lint errors
nick4598 Apr 15, 2024
a4fc76b
Version bump [skip actions]
imodeljs-admin Apr 16, 2024
720cdf0
delete test.sh
nick4598 Apr 16, 2024
99747d5
Merge branch 'federation-guid-optimization' of https://github.com/iTw…
nick4598 Apr 16, 2024
029cd66
add @internal to rangesFromRangeAndSkipped
nick4598 Apr 16, 2024
603450b
mark renderRanges internal
nick4598 Apr 16, 2024
2003695
add @module utils to Algo.ts
nick4598 Apr 17, 2024
d787b38
remove reference to finalizeTransformation since its a private function
nick4598 Apr 17, 2024
a5c49ff
unpin build tools and core backend in package/performance-scripts
nick4598 Apr 17, 2024
a120e71
move classidstoskip part of the instance of hcangedinstanceids
nick4598 Apr 18, 2024
7d9c3ed
working attempt I believe
nick4598 Apr 25, 2024
5334380
Merge branch 'main' into nick/manual-idfilter-changing
nick4598 Apr 25, 2024
47c8f92
fix some lint issues, and lock typescript down to 5.2, since 5.3 brea…
nick4598 Apr 26, 2024
428100f
Change files
nick4598 Apr 26, 2024
deccd29
try going back to other ts version to see if docs failure gives bette…
nick4598 Apr 26, 2024
c790a90
Merge branch 'main' into nick/manual-idfilter-changing
nick4598 May 14, 2024
9b3bf77
Merge branch 'main' into nick/manual-idfilter-changing
nick4598 May 14, 2024
9e0bcd2
make it a bit easier to add custom changes
nick4598 Jun 28, 2024
25e369d
Merge branch 'nick/manual-idfilter-changing' of https://github.com/iT…
nick4598 Jun 28, 2024
0f40eca
Merge branch 'main' into nick/manual-idfilter-changing
nick4598 Jun 28, 2024
6f08fbe
fix build error
nick4598 Jun 28, 2024
fdb5055
Merge branch 'main' into nick/manual-idfilter-changing
nick4598 Nov 20, 2024
c31c9fb
oops missed small change
nick4598 Nov 20, 2024
7778b94
package json and pnpm lock
nick4598 Nov 20, 2024
1b6c0ff
add comment hopefully clarifying why we pass this._sourceDbChanges
nick4598 Dec 5, 2024
496a9f4
add some comment, variable renames
nick4598 Dec 5, 2024
5b37e22
remove .only
nick4598 Dec 5, 2024
00da1b2
remove commented line
nick4598 Dec 6, 2024
62f4f21
allow consumer to pass the entitytype for the change they're adding
nick4598 Dec 6, 2024
21c5432
make sure customchanges can only be added after looking at the change…
nick4598 Dec 10, 2024
4383d00
add comment that ionitialize must be called to have sourceDbChanges b…
nick4598 Dec 10, 2024
8d7c6b7
initial changes to support transforms without changesets
nick4598 Dec 10, 2024
fd9c1b5
add 'addCustomChangesCallback' with comment
nick4598 Dec 16, 2024
7924916
call callback in transformer, also move customchanges in tarnsformer …
nick4598 Dec 16, 2024
e576fa6
remove the dummy changesets from the test, allow transformer to run w…
nick4598 Dec 16, 2024
1026202
add todo over addmodeltotupdated
nick4598 Dec 17, 2024
2096b32
only use isEmpty in thea transformer and not exporter
nick4598 Dec 18, 2024
79ef8f6
change comment
nick4598 Dec 18, 2024
a94542d
revert change
nick4598 Dec 18, 2024
25f6611
add another physical model and a definition model to the custom inser…
nick4598 Dec 18, 2024
4fb7071
change name to addCustomChanges
nick4598 Dec 18, 2024
3c34ea6
change name to adCustomChanges in transformer
nick4598 Dec 18, 2024
0ec65c8
add individual custom functions
nick4598 Dec 18, 2024
f7c6c7a
refactor pocessDeLetedOp, make getclassFullnameFromECClassId private,…
nick4598 Dec 20, 2024
1318721
Merge branch 'main' into nick/manual-idfilter-changing
nick4598 Jan 2, 2025
e105fea
remove changedinstancetype
nick4598 Jan 3, 2025
69bc630
add model's modeledELement to element Changes when adding custom mode…
nick4598 Jan 3, 2025
e5d2614
slight change to weird exportChanges behavior
nick4598 Jan 3, 2025
a0834ec
support bulk adds per operationtype? is this good enough?
nick4598 Jan 3, 2025
6ad00d9
extract-api
nick4598 Jan 3, 2025
eef7b36
lint
nick4598 Jan 3, 2025
bb8c3dc
lint
nick4598 Jan 3, 2025
b53d546
change to hasCustomrelationshipchanges
nick4598 Jan 8, 2025
bdb45db
check for undefined explicitly
nick4598 Jan 8, 2025
8dc4667
remove unnecessary ?
nick4598 Jan 8, 2025
87a6d20
small addition to test where we insert an aspect
nick4598 Jan 9, 2025
c10d83c
custom aspect deletes might not be working. revisit tmrw
nick4598 Jan 9, 2025
1052f01
coment out assert on aspect delete for now
nick4598 Jan 10, 2025
f026eaf
move addCustomChanges to transformer class
nick4598 Jan 10, 2025
a5c2c76
switch to hasChanges, fix bad condition check AGAIN!!
nick4598 Jan 10, 2025
691ac00
remove .only
nick4598 Jan 10, 2025
3bab7a6
lint error
nick4598 Jan 10, 2025
3930f78
make sourceDbChanges required
nick4598 Jan 21, 2025
d0229f7
query for all model ids at once
nick4598 Jan 22, 2025
709792e
lint
nick4598 Jan 22, 2025
7cf5482
fix bug where modeled element's model is not added to custom changes …
nick4598 Jan 22, 2025
17daee0
Merge branch 'main' into nick/manual-idfilter-changing
JulijaRamoskiene Feb 18, 2025
30f40d1
AddCustomChanges API tests and additional functionality
JulijaRamoskiene Feb 19, 2025
5a3afac
Updated documentation
JulijaRamoskiene Feb 20, 2025
a52fc42
Marked internal methods and updated documentation
JulijaRamoskiene Feb 21, 2025
47dcc81
Reverted accidental changes
JulijaRamoskiene Feb 21, 2025
34da6f8
Reverted some changes
JulijaRamoskiene Feb 21, 2025
ab44317
Removed 'addCustomCodeSpecChange' and added more tests
JulijaRamoskiene Feb 21, 2025
fc02c49
More tests for addCustom changes
JulijaRamoskiene Feb 24, 2025
ff91198
Removed AddCustomRelationshipChanges api
JulijaRamoskiene Feb 24, 2025
6b036be
Removed unused variable
JulijaRamoskiene Feb 24, 2025
60ce61b
fixed bad revert
JulijaRamoskiene Feb 24, 2025
224155f
Updated changelog
JulijaRamoskiene Feb 24, 2025
8557071
Clean up
JulijaRamoskiene Feb 24, 2025
e48fdb4
Clean up
JulijaRamoskiene Feb 24, 2025
ac16f16
Added comment back
JulijaRamoskiene Feb 27, 2025
ee43cdb
Updated docs
JulijaRamoskiene Feb 28, 2025
8c94965
removed compressed set
JulijaRamoskiene Feb 28, 2025
ae88008
Removed unused import
JulijaRamoskiene Feb 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Add new APIs to support providing custom changes ( not found in a changeset ) to the transformer",
"packageName": "@itwin/imodel-transformer",
"email": "22119573+nick4598@users.noreply.github.com, JulijaRamoskiene@users.noreply.github.com",
"dependentChangeType": "patch"
}
11 changes: 11 additions & 0 deletions common/api/imodel-transformer.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import { EntityReference } from '@itwin/core-common';
import { ExternalSourceAspect } from '@itwin/core-backend';
import { ExternalSourceAspectProps } from '@itwin/core-common';
import { FontProps } from '@itwin/core-common';
import { Id64Arg } from '@itwin/core-bentley';
import { Id64Array } from '@itwin/core-bentley';
import { Id64Set } from '@itwin/core-bentley';
import { Id64String } from '@itwin/core-bentley';
Expand All @@ -36,11 +37,18 @@ import { Relationship } from '@itwin/core-backend';
import { RelationshipProps } from '@itwin/core-backend';
import { Schema } from '@itwin/ecschema-metadata';
import { SchemaKey } from '@itwin/ecschema-metadata';
import { SqliteChangeOp } from '@itwin/core-backend';

// @public
export class ChangedInstanceIds {
constructor(db: IModelDb);
addChange(change: ChangedECInstance): Promise<void>;
// @beta
addCustomAspectChange(changeType: SqliteChangeOp, ids: Id64Arg): void;
// @beta
addCustomElementChange(changeType: SqliteChangeOp, ids: Id64Arg): Promise<void>;
// @beta
addCustomModelChange(changeType: SqliteChangeOp, ids: Id64Arg): Promise<void>;
// (undocumented)
aspect: ChangedInstanceOps;
// (undocumented)
Expand All @@ -49,6 +57,7 @@ export class ChangedInstanceIds {
element: ChangedInstanceOps;
// (undocumented)
font: ChangedInstanceOps;
get hasChanges(): boolean;
static initialize(opts: ChangedInstanceIdsInitOptions): Promise<ChangedInstanceIds | undefined>;
// (undocumented)
model: ChangedInstanceOps;
Expand All @@ -68,6 +77,7 @@ export class ChangedInstanceOps {
deleteIds: Set<string>;
// (undocumented)
insertIds: Set<string>;
get isEmpty(): boolean;
// (undocumented)
updateIds: Set<string>;
}
Expand Down Expand Up @@ -232,6 +242,7 @@ export interface IModelImportOptions {
// @beta
export class IModelTransformer extends IModelExportHandler {
constructor(source: IModelDb | IModelExporter, target: IModelDb | IModelImporter, options?: IModelTransformOptions);
protected addCustomChanges(_sourceDbChanges: ChangedInstanceIds): Promise<void>;
combineElements(sourceElementIds: Id64Array, targetElementId: Id64String): void;
// (undocumented)
protected completePartiallyCommittedAspects(): void;
Expand Down
18 changes: 10 additions & 8 deletions packages/test-app/src/IModelHubUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,14 @@ export namespace IModelHubUtils {
): Promise<ChangesetId> {
return (
// eslint-disable-next-line @itwin/no-internal
await IModelHost.hubAccess.queryChangeset({
accessToken,
iModelId,
changeset: { index: changesetIndex },
})
).id;
(
Comment thread
ViliusRuskys marked this conversation as resolved.
await IModelHost.hubAccess.queryChangeset({
accessToken,
iModelId,
changeset: { index: changesetIndex },
})
).id
);
}

/** Temporarily needed to convert from the legacy ChangesetId to the now preferred ChangeSetIndex.
Expand Down Expand Up @@ -201,8 +203,8 @@ export namespace IModelHubUtils {
return BriefcaseDb.open({
fileName: briefcaseProps.fileName,
readonly: briefcaseArg.briefcaseId
// eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
? briefcaseArg.briefcaseId === BriefcaseIdValue.Unassigned
? // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
briefcaseArg.briefcaseId === BriefcaseIdValue.Unassigned
: false,
});
}
Expand Down
Loading