Added new API's for adding custom changes into IModelExporter.sourceDbChanges - #237
Merged
Conversation
…into federation-guid-optimization
JulijaRamoskiene
changed the title
IModelExporter.sourceDbChangesIModelExporter.sourceDbChanges
Contributor
Author
|
This PR is based on #172 PR. I created this branch from those changes, and stripped logic to support custom relationship changes (supporting delete). |
JulijaRamoskiene
requested review from
DanRod1999,
ViliusRuskys and
aruniverse
February 24, 2025 14:56
DanRod1999
reviewed
Feb 25, 2025
DanRod1999
reviewed
Feb 27, 2025
Contributor
|
Other than my few questions I think this PR looks good. However, if @mindaugasdirg or @ViliusRuskys could review I would greatly appreciate it. Thanks! |
ViliusRuskys
previously approved these changes
Feb 28, 2025
DanRod1999
previously approved these changes
Feb 28, 2025
JulijaRamoskiene
dismissed stale reviews from DanRod1999 and ViliusRuskys
via
February 28, 2025 14:04
ae88008
DanRod1999
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
IModelTransformer:addCustomChanges()IModelExporter:addCustomElementChanges()IModelExporter:addCustomModelChanges()Custom changes should be added by implementing
IModelTransformer:addCustomChanges().AddCustomRelationshipChangeswere not exposed as public, since it would require complex support for delete operation. Instead, relationships are marked as inserted when marking element as inserted.