Skip to content

Fix iModelGrid Filtering to Show Complete Results Across All Data #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aruniverse merged 6 commits into from
Sep 19, 2025
Merged

Fix iModelGrid Filtering to Show Complete Results Across All Data #176

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd56a51
Fixed the filtering issue
Bentley-Vivek Sep 17, 2025
97d90b1
added changelog
Bentley-Vivek Sep 17, 2025
c5e6719
Added test
Bentley-Vivek Sep 18, 2025
8077135
Improved test name
Bentley-Vivek Sep 18, 2025
738a267
Update IModelGrid.test.tsx
aruniverse Sep 19, 2025
adddeea
Rerun the build
Bentley-Vivek Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@itwin/imodel-browser-react/vp-fix-filtering-issue_2025-09-17-09-16.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@itwin/imodel-browser-react",
"comment": "Fix iModelGrid Filtering via postProcessCallback to Show Complete Results Across All Data",
"type": "patch"
}
],
"packageName": "@itwin/imodel-browser-react"
}
12 changes: 11 additions & 1 deletion packages/modules/imodel-browser/src/containers/iModelGrid/IModelGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { _mergeStrings } from "../../utils/_apiOverrides";
import { ContextMenuBuilderItem } from "../../utils/_buildMenuOptions";
import { IModelGhostTile } from "../iModelTiles/IModelGhostTile";
import { IModelTile, IModelTileProps } from "../iModelTiles/IModelTile";
import { useIModelData } from "./useIModelData";
import { DEFAULT_PAGE_SIZE, useIModelData } from "./useIModelData";
import { useIModelTableConfig } from "./useIModelTableConfig";
export interface IModelGridProps {
/**
Expand Down Expand Up @@ -173,6 +173,16 @@ export const IModelGrid = ({
[postProcessCallback, fetchediModels, fetchStatus, searchText]
);

React.useEffect(() => {
Comment thread
aruniverse marked this conversation as resolved.
if (
iModels.length < (pageSize ?? DEFAULT_PAGE_SIZE) &&
fetchMore &&
fetchStatus !== DataStatus.Fetching
) {
fetchMore();
}
}, [iModels.length, pageSize, fetchMore, fetchStatus]);
Comment thread
ben-polinsky marked this conversation as resolved.
Comment thread
ben-polinsky marked this conversation as resolved.

const { columns, onRowClick } = useIModelTableConfig({
iModelActions,
onThumbnailClick,
Expand Down
2 changes: 1 addition & 1 deletion packages/modules/imodel-browser/src/containers/iModelGrid/useIModelData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export interface IModelDataHookOptions {
/** @deprecated in 2.1 It is no longer used as it has no effect on the data fetching. */
viewMode?: ViewType;
}
const DEFAULT_PAGE_SIZE = 100;
export const DEFAULT_PAGE_SIZE = 100;

export const useIModelData = ({
iTwinId,
Expand Down