Fix iModelGrid Filtering to Show Complete Results Across All Data - #176
Merged
Conversation
Bentley-Vivek
marked this pull request as ready for review
September 17, 2025 09:45
aruniverse
approved these changes
Sep 17, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes filtering issues in the IModelGrid component where the postProcessCallback was only filtering against the first batch of data, causing incomplete results and premature "No Results" messages.
- Added a useEffect hook to automatically fetch more data when filtered results are below the page size
- Exported DEFAULT_PAGE_SIZE constant to support the new filtering logic
- Added changelog entry documenting the fix
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| useIModelData.ts | Exports DEFAULT_PAGE_SIZE constant for use in filtering logic |
| IModelGrid.tsx | Adds useEffect hook to continue fetching data when filtered results are insufficient |
| vp-fix-filtering-issue_2025-09-17-09-16.json | Documents the patch-level change for filtering fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
aruniverse
enabled auto-merge (squash)
September 19, 2025 11:01
auto-merge was automatically disabled
September 19, 2025 11:52
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with the IModelGrid component's handling of filtering via postProcessCallback:
Incomplete Results: The component was only filtering against the first batch of data and not searching subsequent batches
Premature "No Results": When no matches were found in the first batch, it incorrectly displayed "No iModels" even when matches existed in later batches
Problem Details
When we applied filtering via postProcessCallback (e.g., filtering by description or name of iModel):
Solution
Added a useEffect to continue loading data when needed:
Screenshots
Before Fix - Missing Results:

After Fix - Complete Results:
