Add ParCSR overlap capabilities #1448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
victorapm
commented
Jan 2, 2026
src/parcsr_mv/par_csr_overlap.c
Outdated
| *--------------------------------------------------------------------------*/ | ||
|
|
||
| HYPRE_Int | ||
| hypre_ParCSRMatrixExtractLocalOverlap(hypre_ParCSRMatrix *A, |
Contributor
Author
There was a problem hiding this comment.
Consider hypre_ParCSRMatrixCreateLocalOverlap
Contributor
Author
There was a problem hiding this comment.
Changed to hypre_ParCSRMatrixCreateExtendedMatrix
Contributor
Author
|
@liruipeng @rfalgout I'm refactoring the test driver that I added and will open a separate PR for it. This PR is ready for review when you have time. Thanks! |
rfalgout
approved these changes
Jan 8, 2026
Contributor
rfalgout
left a comment
rfalgout
left a comment
There was a problem hiding this comment.
This looks good to me, Victor. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the core infrastructure for computing overlapping subdomains in ParCSR matrices. This is the first step towards implementing overlapping Schwarz preconditioners in hypre.
Main changes are given below:
par_csr_overlap.h: Defines thehypre_OverlapDatastructure and associated accessor macros to store extended subdomain information.par_csr_overlap.c: Implements the overlap computation logic, including:hypre_OverlapDataCreateandhypre_OverlapDataDestroy.hypre_ParCSRMatrixComputeOverlap: Determines extended row indices for a given overlap order.hypre_ParCSRMatrixGetExtendedRows: Handles MPI communication to retrieve external matrix rows.hypre_ParCSRMatrixBuildExtendedMatrix: Constructs the local extended matrix.src/parcsr_mv/CMakeLists.txt: Added new source files to the build system.src/parcsr_mv/protos.h: Added prototypes for the new functions.src/parcsr_mv/par_csr_matrix.c: Minor cleanup in error handling logic.TODOs
test_csr_overlap.c)