Skip to content

Conversation

@victorapm
Copy link
Contributor

  • Refactor test_csr_overlap.c and reduce its size
  • Add benchmark-matmat mode to test_csr_overlap.c to serve as a reference for ParCSRMatrix overlap calculations
  • Add TEST_unit folder in src/test for unit testing
  • Add unit test job to machine-tux408.sh regression test

Depends on #1448

@victorapm victorapm requested a review from rfalgout January 9, 2026 04:32
Copy link
Contributor

@rfalgout rfalgout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't understand the need for the cmake targets, but that's okay. Thanks!

@victorapm
Copy link
Contributor Author

Thanks, Rob! Just removed an old ctest entry that is not needed. The other two remaining are for 1. running the unit tests when invoking ctest from the build directory and 2. a convenience target that allows running unit tests via make unit_tests

@victorapm victorapm mentioned this pull request Jan 9, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants