Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix brfs bug, update tests and docs, add example #4

Merged
merged 6 commits into from
Dec 18, 2016
Merged

Conversation

ungoldman
Copy link
Member

@ungoldman ungoldman commented Dec 17, 2016

  • Renamed "Example Test" to "API Contract", added htmlToElement and getNode.
  • Ran fixpack on package.json.

Resolves #1 #3 #5

@ungoldman
Copy link
Member Author

@bcomnes Actually I'm not sure why these extra methods are here:

  • htmlElement
  • getNode
  • rawPath (path to Entypo+)

dat-icons only exposes the svg path -- what's the advantage of exposing these? Asking for the sake of understanding and documenting.

@ungoldman
Copy link
Member Author

Fixed #5, added an example, added icon names to readme, added API documentation to readme.

@ungoldman
Copy link
Member Author

getNode and htmlToElement are useful, I get it now.

Not sure about rawPath though.

If a user wants the entire Entypo+ collection they can just download it.

I think we should exclude it from the package when publishing so users aren't needlessly getting an extra copy of the font collection buried in their node_modules directory.

@ungoldman ungoldman changed the title add all exports to API contract test fix brfs bug, update tests and docs, add example Dec 18, 2016
@ungoldman ungoldman merged commit 89ed71a into master Dec 18, 2016
@ungoldman ungoldman deleted the tests branch December 18, 2016 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document available icons.
1 participant