Skip to content

doesn't work with brfs #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ungoldman opened this issue Dec 17, 2016 · 2 comments
Closed

doesn't work with brfs #5

ungoldman opened this issue Dec 17, 2016 · 2 comments

Comments

@ungoldman
Copy link
Member

because of this brfs issue: browserify/brfs#36

You can't use variables since the expression has to be statically analyzable, i.e. Known at build time, not run time.

So we have to do the path.join inside of the main() function.
@ungoldman ungoldman mentioned this issue Dec 18, 2016
Merged
ungoldman added a commit that referenced this issue Dec 18, 2016
@ungoldman
fix: inline path.join for brfs (#5)
4351d95
ungoldman added a commit that referenced this issue Dec 18, 2016
@ungoldman
fix: inline path.join for brfs (#5)
0b3ed86
@ungoldman
Copy link
Member Author

Fixed in #4, needs a release though.

@ungoldman
Copy link
Member Author

Fix released in v1.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ungoldman