Skip to content

fix: export DIDCommConnection class on the SDK back to have the ability to establish connections with dids and oob codes #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

fix: export DIDCommConnection class on the SDK back to have the ability to establish connections with dids and oob codes #412

merged 1 commit into from
Mar 26, 2025

Conversation

elribonazo
Copy link
Contributor

Description:

Exposing the DIDcommConnection class to restore the missing functionality

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@elribonazo
fix: export DIDCommConnection class on the SDK back to have the abili…
a0ca79c 
…ty to establish connections with dids directly not just oob

Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
@elribonazo elribonazo requested a review from a team as a code owner March 26, 2025 11:22
@elribonazo elribonazo linked an issue Mar 26, 2025 that may be closed by this pull request
Cannot establish connections anymore into DIDS directly #411
Closed
@elribonazo elribonazo self-assigned this Mar 26, 2025
@elribonazo elribonazo added the bug Something isn't working label Mar 26, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14082058781

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.378%
Totals Coverage Status
Change from base Build 14056499826: 0.0%
Covered Lines: 3445
Relevant Lines: 4378
💛 - Coveralls

@elribonazo elribonazo merged commit 94c70cf into main Mar 26, 2025
6 checks passed
@elribonazo elribonazo deleted the 411-cannot-establish-connections-anymore-into-dids-directly branch March 26, 2025 11:32
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hyperledger Identus - Roadmap Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtis-h curtis-h curtis-h approved these changes

Assignees

@elribonazo elribonazo

Labels
bug Something isn't working
Projects
Hyperledger Identus - Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot establish connections anymore into DIDS directly
3 participants
@elribonazo @coveralls @curtis-h