fix: guard lineInfo getter against undefined logicalLineInfo#96
Merged
Conversation
The existing patch guarded logicalLineInfo inside GhosttyTerminalRenderable's own methods, but @opentui/core's base class TextBufferRenderable has a lineInfo getter that also calls logicalLineInfo — and its scrollHeight/ scrollWidth properties access the result without null checks. Override the getter to return a safe empty fallback when logicalLineInfo is undefined. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
🎉 This PR is included in version 2.10.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logicalLineInfoinsideGhosttyTerminalRenderable's own methods (renderSelf,getScrollPositionForLine)@opentui/core's base classTextBufferRenderablehas alineInfogetter that also callslogicalLineInfo, and itsscrollHeight/scrollWidthproperties access the result without null checks — causing crashes in consumerslineInfogetter onGhosttyTerminalRenderable.prototypeto return an empty fallback whenlogicalLineInfois undefined@opentui/core(0.1.90) andghostty-opentui(1.4.7) are at latest — no upstream fix availableTest plan
bun installapplies patch successfullybun run buildbundles the override intodist/numux.jsEMPTY_LINE_INFOfallback andlineInfogetter present in bundle🤖 Generated with Claude Code