fix: use lineStartCols instead of missing lineStarts property#97
Merged
Conversation
The ghostty-opentui code accesses lineInfo.lineStarts, but @opentui/core's FFI actually returns lineStartCols. The previous fix guarded against lineInfo being null, but the real crash was lineInfo.lineStarts being undefined because the property doesn't exist on the returned LineInfo object. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
🎉 This PR is included in version 2.10.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ghostty-opentuicode accesseslineInfo.lineStarts, but@opentui/core's FFI returnslineStartCols— thelineStartsproperty doesn't exist on the returnedLineInfoobjectlineInfobeing null/undefined, but the actual crash waslineInfo.lineStartsbeingundefinedlineStartColswith fallback tolineStartsfor compatibility, and added?.ontextBufferViewin the getterTest plan
🤖 Generated with Claude Code