ci: run PR-changed example/model files on sim and a2a3#334
Conversation
Add a detect-changes job that lists the runnable example/model files changed by a PR (filtered to those with a __main__ entrypoint), and gate the sim and a2a3 jobs on it. On a PR these jobs now run only the changed files instead of the full examples suite, so model files — previously untested on PRs and only covered by the scheduled daily_ci — get exercised on a2a3 and the simulators. Push to main and manual dispatch keep running the full examples suite. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The a2a3 job runs inside a container whose default shell is dash, which
cannot parse the bash-array logic (failed=(), ${#failed[@]}) added in
hw-native-sys#334. Pin shell: bash on both the sim and a2a3 run steps so the script
parses consistently regardless of the runner's default shell.
## Summary - Delete `.github/daily_ci_cases.tsv`, which referenced model files (`qwen3_14b_decode.py`, `qwen3_14b_decode_full.py`) renamed/split in #319 and was therefore stale - Remove the TSV-reading "extras" logic from both jobs in `daily_ci.yml`; daily CI now watches only the default no-arg invocation of every model file - Fix the `a2a3` job failing on push-to-main: pin `shell: bash` on the sim and a2a3 run steps. The container's default shell is dash, which cannot parse the `failed=()` / `${#failed[@]}` bash-array logic added in #334. The bug was masked on #334's own PR because no example/model `.py` files changed, so the device jobs were skipped. ## Related Issues N/A
1 participant
Summary
detect-changesjob that lists the runnableexamples//models/files a PR changed — filtered to files with a__main__entrypoint, excluding drafts and deleted files.sim(a2a3sim/a5sim) anda2a3jobs ondetect-changes: a PR touching no runnable file skips them entirely.sim/a2a3now run only the changed files instead of the fullexamples/suite, somodels/files — previously untested on PRs and only covered by the scheduleddaily_ci— get exercised on a2a3 and the simulators.mainand manual dispatch keep running the fullexamples/suite (unchanged behavior);daily_cistill provides full model coverage onmain.Related Issues
N/A