CI: drop daily-CI extra cases; fix dash-incompatible test step#336
Conversation
Remove .github/daily_ci_cases.tsv and the TSV-reading logic from daily_ci.yml. The TSV referenced model files that were renamed/split in hw-native-sys#319, leaving it stale. Daily CI now watches only the default no-arg invocation of every model file.
📝 WalkthroughWalkthroughThe daily CI workflow simplifies model test execution by removing parameterized case handling. Both ChangesDaily CI Model Test Simplification
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request deletes the configuration file for daily CI parametric cases. A review comment points out that the PR description mentions changes to the CI workflow file which are not present in the diff, warning that deleting this file without updating the workflow will likely cause CI failures.
| @@ -1,12 +0,0 @@ | |||
| # Daily-CI extra parametric cases. | |||
The a2a3 job runs inside a container whose default shell is dash, which
cannot parse the bash-array logic (failed=(), ${#failed[@]}) added in
hw-native-sys#334. Pin shell: bash on both the sim and a2a3 run steps so the script
parses consistently regardless of the runner's default shell.
Summary
.github/daily_ci_cases.tsv, which referenced model files (qwen3_14b_decode.py,qwen3_14b_decode_full.py) renamed/split in Refactor Qwen3 decode and split final head #319 and was therefore staledaily_ci.yml; daily CI now watches only the default no-arg invocation of every model filea2a3job failing on push-to-main: pinshell: bashon the sim and a2a3 run steps. The container's default shell is dash, which cannot parse thefailed=()/${#failed[@]}bash-array logic added in ci: run PR-changed example/model files on sim and a2a3 #334. The bug was masked on ci: run PR-changed example/model files on sim and a2a3 #334's own PR because no example/model.pyfiles changed, so the device jobs were skipped.Related Issues
N/A