Skip to content

CI: drop daily-CI extra cases; fix dash-incompatible test step#336

Merged
zhangqi-chen merged 2 commits into
hw-native-sys:mainfrom
zhangqi-chen:ci/drop-daily-ci-extra-cases
May 20, 2026
Merged

CI: drop daily-CI extra cases; fix dash-incompatible test step#336
zhangqi-chen merged 2 commits into
hw-native-sys:mainfrom
zhangqi-chen:ci/drop-daily-ci-extra-cases

Conversation

@zhangqi-chen
Copy link
Copy Markdown
Collaborator

@zhangqi-chen zhangqi-chen commented May 20, 2026

Summary

Related Issues

N/A

Remove .github/daily_ci_cases.tsv and the TSV-reading logic from
daily_ci.yml. The TSV referenced model files that were renamed/split
in hw-native-sys#319, leaving it stale. Daily CI now watches only the default
no-arg invocation of every model file.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

The daily CI workflow simplifies model test execution by removing parameterized case handling. Both model-tests-sim and model-tests-a2a3 jobs now run only the default non-draft models under models once each, without per-case arguments, and the logic that read .github/daily_ci_cases.tsv for extra cases is removed.

Changes

Daily CI Model Test Simplification

Layer / File(s) Summary
Simplify model-tests-sim and model-tests-a2a3 jobs
.github/workflows/daily_ci.yml
Both model test jobs are adjusted to execute only the default set of non-draft models under models exactly once with no additional per-case arguments, and the follow-up parameterized case logic is removed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • hw-native-sys/pypto-lib#145: Both PRs modify the GitHub Actions test runner logic in .github/workflows/daily_ci.yml to control which models/*.py files are executed (with *draft* excluded), so this PR's cleanup of parameterized case behavior is directly related.

Poem

🐰 The CI learns to hop more straight,
No winding paths through draft or state,
Each model runs its course just once—
The workflow's simpler by bunches!
One hop per script, no extra dance! 🎯

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the main changes: dropping daily-CI extra cases and fixing a shell compatibility issue in the test step.
Description check ✅ Passed The description is directly related to the changeset, detailing the removal of stale TSV file, deletion of extras logic, and shell compatibility fix.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deletes the configuration file for daily CI parametric cases. A review comment points out that the PR description mentions changes to the CI workflow file which are not present in the diff, warning that deleting this file without updating the workflow will likely cause CI failures.

@@ -1,12 +0,0 @@
# Daily-CI extra parametric cases.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request description states that logic was removed from daily_ci.yml, but that file is not included in the changes. Deleting this TSV file without updating the CI workflow that references it will likely cause CI failures.

The a2a3 job runs inside a container whose default shell is dash, which
cannot parse the bash-array logic (failed=(), ${#failed[@]}) added in
 hw-native-sys#334. Pin shell: bash on both the sim and a2a3 run steps so the script
parses consistently regardless of the runner's default shell.
@zhangqi-chen zhangqi-chen changed the title CI: drop daily-CI extra parametric cases CI: drop daily-CI extra cases; fix dash-incompatible test step May 20, 2026
@zhangqi-chen zhangqi-chen merged commit 38cd262 into hw-native-sys:main May 20, 2026
6 checks passed
@zhangqi-chen zhangqi-chen deleted the ci/drop-daily-ci-extra-cases branch May 20, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant