Fix TPush CPU-SIM A5 support issue#109
Conversation
There was a problem hiding this comment.
Code Review
This pull request modifies the TPush implementation to correctly handle DIR_BOTH pipes by incorporating TileProd::Loc checks when determining the transfer direction. Feedback includes a potential bug where TileType::Mat transfers might be incorrectly recorded due to an incomplete check in the underlying IsC2VProducerTile function, along with a suggestion to improve code formatting and comment placement for better readability.
e747033 to
127f262
Compare
a3f2a45 to
053f2bf
Compare
|
Triage review (2026-05-08): this is the focused PR in the TPUSH CPU-SIM cluster, and the patch applies to current Issues to fix before review:
Please add or reference targeted CPU-SIM regression coverage for the failing #101 cases and run at least the relevant |
cbba122 to
25d33de
Compare
Hi. What is this CI check? How to run it? |
|
1 |
To fix issue #101