fix(benchmark) : fixing video benchmark #2094
Open
+43
−244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the video benchmarking infrastructure by removing deprecated code, updating file naming conventions, and modernizing the timing/decoding approach.
- Removes deprecated files (
capture_camera_feed.py,benchmark.py) and their outdatedTimeBenchmarkclass - Updates frame filename format from
frame_XXXXXX.pngtoframe-XXXXXX.pngthroughout - Replaces custom
TimeBenchmarkwith the existingTimerManagerutility and adds thread synchronization
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| benchmarks/video/run_video_benchmark.py | Modernizes benchmarking by switching to TimerManager, updates frame file naming pattern, refactors nested loops to use itertools.product, adds thread locking for video decoding, updates default datasets and codecs |
| benchmarks/video/capture_camera_feed.py | Removes deprecated camera feed capture utility |
| benchmarks/video/benchmark.py | Removes deprecated TimeBenchmark class that has been replaced by TimerManager |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| encoding_cfg["vcodec"] = video_codec | ||
| encoding_cfg["pix_fmt"] = pixel_format | ||
| for duet in [ | ||
| dict(zip(encoding_benchmarks.keys(), unique_combination, strict=False)) |
There was a problem hiding this comment.
The strict=False parameter is unnecessary when the lengths are guaranteed to match by itertools.product. Consider removing it or using strict=True to catch potential bugs if the data structure changes.
Suggested change
| dict(zip(encoding_benchmarks.keys(), unique_combination, strict=False)) | |
| dict(zip(encoding_benchmarks.keys(), unique_combination)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This PR fixes the video benchmark to work with the latest developments.
How it was tested + How to checkout & try? (for the reviewer)
In a python environment with LeRobot installed with the
video_benchmarkoption, run :