Skip to content

Preserve features after IterableDataset.add_column #8316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sridhar-3009 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

Preserve features after IterableDataset.add_column #8316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/datasets/iterable_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4036,7 +4036,14 @@ def add_column(self, name: str, column: Union[list, np.array]) -> "IterableDatas
Returns:
`IterableDataset`
"""
return self.map(partial(add_column_fn, name=name, column=column), with_indices=True)
original_features = self._info.features.copy() if self._info.features else None
ds_iterable = self.map(partial(add_column_fn, name=name, column=column), with_indices=True)
if original_features is not None:
col_table = pa.table({name: column})
new_features = original_features.copy()
new_features[name] = Features.from_arrow_schema(col_table.schema)[name]
ds_iterable._info.features = new_features
return ds_iterable

def rename_column(self, original_column_name: str, new_column_name: str) -> "IterableDataset":
"""
Expand Down