Preserve features after IterableDataset.add_column#8316
Open
sridhar-3009 wants to merge 1 commit into
Open
Conversation
`add_column` delegates to `map` but never updates the returned dataset's features schema. Calling `add_column` on a typed IterableDataset silently drops the `features` attribute (returns `None`), breaking any code that inspects schema after the operation. Follow the same pattern as `rename_columns`: save the existing features before the map call, infer the new column's type from the column data via PyArrow, then write the merged Features back to `_info.features`. Fixes huggingface#5752.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
IterableDataset.add_columndelegates tomapbut never propagates the schema. After the call,dataset.featuresisNoneeven when the original dataset had a typed schema, silently breaking all downstream code that inspects features.Root cause
The implementation is a one-liner:
mapwithout an explicitfeaturesargument does not infer schema from the mapper output.Fix
Follow the same pattern used by
rename_columns: snapshot the existing features before the map, infer the new column's type from the column data via PyArrow (one line, pyarrow is already a required dependency), merge, and write back to_info.features.If the original dataset had no features schema (
features is None), behavior is unchanged.Fixes #5752.