Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NickAkhmetov/HMP-540/Update get_view_config_builder to use get_assaytype instead of get_assay #82

Merged
merged 19 commits into from
Dec 19, 2023

Conversation

NickAkhmetov
Copy link
Collaborator

@NickAkhmetov NickAkhmetov commented Dec 12, 2023

This PR adds support for the assaytype endpoint instead of get_assay. This is a breaking change which requires revisions to support, so it is accompanied by a minor version change (to v0.1.0)

I validated the functionality of each builder using a local portal instance (using the branch hubmapconsortium/portal-ui#3361); each visualization appeared to work as expected when pointed at prod data. I have also updated the tests and fixtures accordingly to reflect the new interface.

TODOs from December 14

  • Image pyramid visualizations are functional
  • I have identified UUID's for datasets that trigger each of the given assaytype builders and created assaytype fixtures corresponding to those UUID's
  • I updated the other "good" test fixtures' UUIDs to match the identified entities
  • still need to debug the "good entity" tests and get them to actually pass
  • still need to come up with a strategy to handle the "bad entity" tests

TODOs from December 12

  • Troubleshoot seqfish image pyramid display
  • update current uses of get_assay within portal-visualization

@NickAkhmetov NickAkhmetov changed the title NickAkhmetov/Update get_view_config_builder to use get_assaytype instead of get_assay NickAkhmetov/HMP-540/Update get_view_config_builder to use get_assaytype instead of get_assay Dec 18, 2023
@NickAkhmetov NickAkhmetov marked this pull request as ready for review December 19, 2023 15:37
Copy link
Collaborator

@john-conroy john-conroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We touched upon it briefly, but should we use the prod ingest url?

@NickAkhmetov NickAkhmetov merged commit 2db9bbc into main Dec 19, 2023
2 checks passed
@NickAkhmetov NickAkhmetov deleted the nickakhmetov/soft-assay-endpoint branch December 19, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants