-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NickAkhmetov/HMP-540/Update get_view_config_builder
to use get_assaytype
instead of get_assay
#82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_view_config_builder
to use get_assaytype
instead of get_assay
get_view_config_builder
to use get_assaytype
instead of get_assay
john-conroy
reviewed
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! We touched upon it briefly, but should we use the prod ingest url?
john-conroy
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
assaytype
endpoint instead ofget_assay
. This is a breaking change which requires revisions to support, so it is accompanied by a minor version change (to v0.1.0)I validated the functionality of each builder using a local portal instance (using the branch hubmapconsortium/portal-ui#3361); each visualization appeared to work as expected when pointed at prod data. I have also updated the tests and fixtures accordingly to reflect the new interface.
TODOs from December 14
TODOs from December 12
get_assay
within portal-visualization